Skip to content

[HOLD for payment 2023-11-30] mWeb/Safari - Chat - The top part of the UI is enlarged when posting bold text #31580

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.1.4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with a new account
  3. Open a new conversation
  4. Type in "Text"

Expected Result:

The top UI shouldn't be enlarged

Actual Result:

The top part of the UI is enlarged when posting bold text. The UI is blocking a big portion of the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6284403_1700509839186.Xjtn1260.mp4

View all open jobs on GitHub

Activity

  1. github-actions commented on Nov 20, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Nov 20, 2023

    @melvin-bot

    Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. melvin-bot commented on Nov 20, 2023

    @melvin-bot

    📣 @github-actions[bot]! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  4. amyevans commented on Nov 20, 2023

    @amyevans
    Contributor

    Reproduced on staging on my physical device, need to figure out how to access local web on a simulator to make more progress though

  5. amyevans commented on Nov 21, 2023

    @amyevans
    Contributor

    Got access to mweb solved with https://stackoverflowteams.com/c/expensify/questions/137 (and then used this workaround to get dev working on my physical device).

    However I haven't been able to reproduce (on main) 🤔 . I'll try on the staging branch.

  6. amyevans commented on Nov 21, 2023

    @amyevans
    Contributor

    Okay nevermind, I can reproduce on main, you just have to do it twice in a row and it's reproducible the second time

  7. amyevans commented on Nov 21, 2023

    @amyevans
    Contributor

    Not reproducible when I revert #21298 locally, so I'm going to open a PR to revert that.

  8. amyevans commented on Nov 21, 2023

    @amyevans
    Contributor

    Getting

    Sorry, this pull request couldn’t be reverted automatically. It may have already been reverted, or the content may have changed since it was merged.

    when trying to do that via the web interface, so I'll do it manually (there was a merge conflict when doing it locally so I guess that's it)

  9. lukemorawski commented on Nov 21, 2023

    @lukemorawski
    Contributor

    Interesting one. Looks like it happens on newly created chats, on first message regardless if it's a bold text or not. Having a look.

  10. amyevans commented on Nov 21, 2023

    @amyevans
    Contributor

    Confirmed on staging this issue is no longer present following the CP, going to close!

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 23, 2023
  12. changed the title [-]mWeb/Safari - Chat - The top part of the UI is enlarged when posting bold text[/-] [+][HOLD for payment 2023-11-30] mWeb/Safari - Chat - The top part of the UI is enlarged when posting bold text[/+] on Nov 23, 2023
  13. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-30. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions