You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-12-04] Investigate Navigation.goBack issue on page reload #31661
Please re-state the problem that we are trying to solve in this issue.
When the current route is a RHP referral page and the application is reloaded, user is navigated back to the same page on click of Back button or Got it.
What is the root cause of that problem?
When we reload the application, the application will launch the app with deep link url here. Here we wait for the routes to be populated in navigation here and, later, perform navigation here using PUSH. As we are additionally pushing the route, there will be two route entries for RHP page as shown below. This is the root cause for the user to be navigated back to the same page.
The same behaviour can be observed for Start chat RHP page.
Additionally, desktop applications have problem for deep link URL due to the additional call to navigate function. I have also added a proposal there
What changes do you think we should make in order to solve the problem?
To solve the problem, we can simply remove the call to navigate function here
changed the title [-]Investigate Navigation.goBack issue on page reload[/-][+][HOLD for payment 2023-12-04] Investigate Navigation.goBack issue on page reload[/+]on Nov 27, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-04. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
[@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@luacmartins] Determine if we should create a regression test for this bug.
[@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Nov 21, 2023
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 21, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)rojiphil commentedon Nov 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
When the current route is a RHP referral page and the application is reloaded, user is navigated back to the same page on click of
Backbutton orGot it.What is the root cause of that problem?
When we reload the application, the application will launch the app with deep link url here. Here we wait for the routes to be populated in navigation here and, later, perform navigation here using
PUSH. As we are additionally pushing the route, there will be two route entries for RHP page as shown below. This is the root cause for the user to be navigated back to the same page.The same behaviour can be observed for
Start chatRHP page.Additionally, desktop applications have problem for deep link URL due to the additional call to
navigatefunction. I have also added a proposal thereWhat changes do you think we should make in order to solve the problem?
To solve the problem, we can simply remove the call to
navigatefunction here- Navigation.navigate(route, CONST.NAVIGATION.ACTION_TYPE.PUSH);What alternative solutions did you explore? (Optional)
The alternate approach used was to replace
PUSHwithREPLACElike this.Navigation.navigate(route, CONST.NAVIGATION.ACTION_TYPE.REPLACE);
melvin-bot commentedon Nov 22, 2023
abdulrahuman5196 commentedon Nov 22, 2023
This issue should be solved by this PR - #31702
[-]Investigate Navigation.goBack issue on page reload[/-][+][HOLD for payment 2023-12-04] Investigate Navigation.goBack issue on page reload[/+]melvin-bot commentedon Nov 27, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 27, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-04. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
melvin-bot commentedon Nov 27, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
luacmartins commentedon Nov 27, 2023
I think we can close this one, since we have another issue to solve this.