You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Needs payment][Track Tax] Add new input fields for tax tracking in Money requests #31672
This issue is divided in 2 phases to keep PR's small, test use cases efficiently and deliver in milestones
Phase 1
In phase 1, we create a simple input fields that can allow inserting, editing and viewing tax details
As discussed in design doc, we need to create tax selector and tax amount components. Also add handles to update transaction tax details in Onyx and also pass tax details to API
Components and handlers should be created in a new way following this refactor PR #28618
Phase 2
In phase 2, we'll add more logic to tax input fields.
Handling and displaying system messages when tax rates are updated
When updating category, we need to apply category expense rule and hence update tax rate field and tax amount field accordingly
As mentioned in design doc, only specific users can edit the tax details depending on the state of report
Why is this important?
To allow users to track tax on the expenses, and migration users to newdot.
Solution
Implement the section of the design doc
Issue OwnerCurrent Issue Owner: @kadiealexanderUpwork Automation - Do Not Edit
changed the title [-]Add new input fields for tax tracking in Money requests[/-][+][Wave 8: Add tax tracking] Add new input fields for tax tracking in Money requests[/+]on Nov 22, 2023
There were some regressions coming out of it, but since it was a new feature and lots of new introductions to App, i think it's fine to pay full payment.
changed the title [-][Track Tax] Add new input fields for tax tracking in Money requests[/-][+][Needs payment][Track Tax] Add new input fields for tax tracking in Money requests[/+]on May 7, 2024
Activity
melvin-bot commentedon Nov 22, 2023
Triggered auto assignment to @kadiealexander (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.[-]Add new input fields for tax tracking in Money requests[/-][+][Wave 8: Add tax tracking] Add new input fields for tax tracking in Money requests[/+]MonilBhavsar commentedon Nov 24, 2023
Discussing here https://expensify.slack.com/archives/C03UK30EA1Z/p1700633473392829
teneeto commentedon Nov 27, 2023
Hi, I'm Eto from Callstack - expert contributor group - and I would like to take care of this issue.
61 remaining items
melvin-bot commentedon May 1, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01fe3f2f6f3d94b969
melvin-bot commentedon May 1, 2024
Current assignee @alitoshmatov is eligible for the Internal assigner, not assigning anyone new.
kadiealexander commentedon May 1, 2024
@MonilBhavsar I'm finding this hard to follow, could you please quickly summarise who is due payment for what?
MonilBhavsar commentedon May 1, 2024
Payment summary: Pay $1000 to @alitoshmatov for reviewing two PR's created before the price update
There were some regressions coming out of it, but since it was a new feature and lots of new introductions to App, i think it's fine to pay full payment.
MonilBhavsar commentedon May 1, 2024
Eto Olei is from Callstack and does not need payment
alitoshmatov commentedon May 6, 2024
@kadiealexander Bump
kadiealexander commentedon May 7, 2024
@alitoshmatov I've sent you an upwork contract.
[-][Track Tax] Add new input fields for tax tracking in Money requests[/-][+][Needs payment][Track Tax] Add new input fields for tax tracking in Money requests[/+]alitoshmatov commentedon May 7, 2024
@kadiealexander Accepted the offer
kadiealexander commentedon May 8, 2024
Payouts due:
Upwork job is here.