Skip to content

[Needs payment][Track Tax] Add new input fields for tax tracking in Money requests #31672

Closed

Description

@MonilBhavsar

Problem

Internal master Issue:https://github.com/Expensify/Expensify/issues/338212
Coming from this section in design doc https://docs.google.com/document/d/1nkusVPiYN3uYCJAH_2XknBv_oPpNOifVxheuxRvFTxs/edit?pli=1#bookmark=id.l319wrhremwa

This issue is divided in 2 phases to keep PR's small, test use cases efficiently and deliver in milestones

Phase 1

In phase 1, we create a simple input fields that can allow inserting, editing and viewing tax details
As discussed in design doc, we need to create tax selector and tax amount components. Also add handles to update transaction tax details in Onyx and also pass tax details to API

Components and handlers should be created in a new way following this refactor PR #28618

Phase 2

In phase 2, we'll add more logic to tax input fields.

  • Handling and displaying system messages when tax rates are updated
  • When updating category, we need to apply category expense rule and hence update tax rate field and tax amount field accordingly
  • As mentioned in design doc, only specific users can edit the tax details depending on the state of report

Why is this important?

To allow users to track tax on the expenses, and migration users to newdot.

Solution

Implement the section of the design doc

Issue OwnerCurrent Issue Owner: @kadiealexander
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fe3f2f6f3d94b969
  • Upwork Job ID: 1785541230062321664
  • Last Price Increase: 2024-05-01

Activity

  1. self-assigned this
    on Nov 22, 2023
  2. melvin-bot commented on Nov 22, 2023

    @melvin-bot
  3. changed the title [-]Add new input fields for tax tracking in Money requests[/-] [+][Wave 8: Add tax tracking] Add new input fields for tax tracking in Money requests[/+] on Nov 22, 2023
  4. MonilBhavsar commented on Nov 24, 2023

    @MonilBhavsar
    ContributorAuthor
  5. teneeto commented on Nov 27, 2023

    @teneeto
    Contributor

    Hi, I'm Eto from Callstack - expert contributor group - and I would like to take care of this issue.

  6. 61 remaining items

  7. added
    InternalRequires API changes or must be handled by Expensify staff
    on May 1, 2024
  8. melvin-bot commented on May 1, 2024

    @melvin-bot
  9. melvin-bot commented on May 1, 2024

    @melvin-bot

    Current assignee @alitoshmatov is eligible for the Internal assigner, not assigning anyone new.

  10. kadiealexander commented on May 1, 2024

    @kadiealexander
    Contributor

    @MonilBhavsar I'm finding this hard to follow, could you please quickly summarise who is due payment for what?

  11. MonilBhavsar commented on May 1, 2024

    @MonilBhavsar
    ContributorAuthor

    Payment summary: Pay $1000 to @alitoshmatov for reviewing two PR's created before the price update

    1. feat: add edit fields for tax tracking #33927
    2. feat: add new input fields for tax tracking #32550

    There were some regressions coming out of it, but since it was a new feature and lots of new introductions to App, i think it's fine to pay full payment.

  12. MonilBhavsar commented on May 1, 2024

    @MonilBhavsar
    ContributorAuthor

    Eto Olei is from Callstack and does not need payment

  13. alitoshmatov commented on May 6, 2024

    @alitoshmatov
    Contributor
  14. kadiealexander commented on May 7, 2024

    @kadiealexander
    Contributor

    @alitoshmatov I've sent you an upwork contract.

  15. changed the title [-][Track Tax] Add new input fields for tax tracking in Money requests[/-] [+][Needs payment][Track Tax] Add new input fields for tax tracking in Money requests[/+] on May 7, 2024
  16. alitoshmatov commented on May 7, 2024

    @alitoshmatov
    Contributor

    @kadiealexander Accepted the offer

  17. kadiealexander commented on May 8, 2024

    @kadiealexander
    Contributor

    Payouts due:

    Upwork job is here.

  18. moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collecton May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.ReviewingHas a PR in review

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions