Skip to content

[$500] Close account - No message about successful account closure #31690

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.2-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Go to Settings -> Security - Close account
  4. Enter you account email and confirm the action

Expected Result:

The message about the successful closing of the account appears

Actual Result:

No message about successful account closure

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6286973_1700650689195.Recording__6847.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016f060a06c71f21d9
  • Upwork Job ID: 1727299354646183936
  • Last Price Increase: 2023-11-22

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 22, 2023
  2. changed the title [-]Close account - No message about successful account closure[/-] [+][$500] Close account - No message about successful account closure[/+] on Nov 22, 2023
  3. melvin-bot commented on Nov 22, 2023

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 22, 2023
  5. melvin-bot commented on Nov 22, 2023

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. melvin-bot commented on Nov 22, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Nov 22, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

  8. 5 remaining items

  9. shubham1206agra commented on Nov 22, 2023

    @shubham1206agra
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue

    Close account - No message about successful account closure

    What is the root cause of that problem?

    This is due to introduced latency in the save function of PersistedRequests in #30425, the CloseAccount API is never called and redirectToSignIn clears the PersistedRequests queue.

    What changes do you think we should make in order to solve the problem?

    Use makeRequestWithSideEffects instead of write in the CloseAccount API call.

    What alternative solutions did you explore? (Optional)

    Maybe revert the #30425

  10. dukenv0307 commented on Nov 22, 2023

    @dukenv0307
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Close account - No message about successful account closure

    What is the root cause of that problem?

    This is from this PR #30425

    We clear the requests immediately after adding the CloseAccount request, so it never executes, the account was never closed as well.

    What changes do you think we should make in order to solve the problem?

    After calling CloseAccount API, Listen to Onyx account, if account.success becomes have value, only then we call redirectToSignIn

    What alternative solutions did you explore? (Optional)

    Use makeRequestWithSideEffects, but it’s an antipattern that’s discouraged in the code base.

  11. flodnv commented on Nov 22, 2023

    @flodnv
    Contributor
  12. WojtekBoman commented on Nov 22, 2023

    @WojtekBoman
    Contributor

    Hi, I think that this issue can be fixed by adding one change to the save method in PersistedRequests. I proposed a change here, waiting for response from @roryabraham

  13. luacmartins commented on Nov 22, 2023

    @luacmartins
    Contributor

    We reverted #30425. @WojtekBoman can you please add this issue to your list when you work on v2 of #30425?

  14. luacmartins commented on Nov 22, 2023

    @luacmartins
    Contributor

    Offending PR was reverted. Removing blocker label.

  15. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 22, 2023
  16. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 22, 2023
  17. luacmartins commented on Nov 22, 2023

    @luacmartins
    Contributor

    Gonna close this issue in favor of the original one - #28172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions