You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Close account - No message about successful account closure #31690
Version Number: v1.4.2-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @
changed the title [-]Close account - No message about successful account closure[/-][+][$500] Close account - No message about successful account closure[/+]on Nov 22, 2023
Please re-state the problem that we are trying to solve in this issue
Close account - No message about successful account closure
What is the root cause of that problem?
This is due to introduced latency in the save function of PersistedRequests in #30425, the CloseAccount API is never called and redirectToSignIn clears the PersistedRequests queue.
What changes do you think we should make in order to solve the problem?
Use makeRequestWithSideEffects instead of write in the CloseAccount API call.
What alternative solutions did you explore? (Optional)
Hi, I think that this issue can be fixed by adding one change to the save method in PersistedRequests. I proposed a change here, waiting for response from @roryabraham
Activity
[-]Close account - No message about successful account closure[/-][+][$500] Close account - No message about successful account closure[/+]melvin-bot commentedon Nov 22, 2023
Job added to Upwork: https://www.upwork.com/jobs/~016f060a06c71f21d9
melvin-bot commentedon Nov 22, 2023
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Nov 22, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (
External)5 remaining items
shubham1206agra commentedon Nov 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue
Close account - No message about successful account closure
What is the root cause of that problem?
This is due to introduced latency in the
savefunction ofPersistedRequestsin #30425, theCloseAccountAPI is never called andredirectToSignInclears thePersistedRequestsqueue.What changes do you think we should make in order to solve the problem?
Use
makeRequestWithSideEffectsinstead ofwritein theCloseAccountAPI call.What alternative solutions did you explore? (Optional)
Maybe revert the #30425
dukenv0307 commentedon Nov 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Close account - No message about successful account closure
What is the root cause of that problem?
This is from this PR #30425
We clear the requests immediately after adding the CloseAccount request, so it never executes, the account was never closed as well.
What changes do you think we should make in order to solve the problem?
After calling CloseAccount API, Listen to Onyx account, if account.success becomes have value, only then we call redirectToSignIn
What alternative solutions did you explore? (Optional)
Use makeRequestWithSideEffects, but it’s an antipattern that’s discouraged in the code base.
flodnv commentedon Nov 22, 2023
Thank you for the proposals! Taking this to Slack for faster resolution: https://expensify.slack.com/archives/C01GTK53T8Q/p1700666993628189?thread_ts=1700655246.224999&cid=C01GTK53T8Q
WojtekBoman commentedon Nov 22, 2023
Hi, I think that this issue can be fixed by adding one change to the save method in PersistedRequests. I proposed a change here, waiting for response from @roryabraham
luacmartins commentedon Nov 22, 2023
We reverted #30425. @WojtekBoman can you please add this issue to your list when you work on v2 of #30425?
luacmartins commentedon Nov 22, 2023
Offending PR was reverted. Removing blocker label.
luacmartins commentedon Nov 22, 2023
Gonna close this issue in favor of the original one - #28172