Skip to content

[$500] Header-Skeleton is not shown in header while the page is loading #31707

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR: #31545

Version Number: 1.4.2-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Navigate to any chat and note the header while it is loading

Expected Result:

When user navigates to any chat , skeleton must be rendered in header while the page is loading.

Actual Result:

When user navigates to any chat , skeleton is not shown in header while the page is loading.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6287151_1700658442315.mskeleton.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010f46a289959ef529
  • Upwork Job ID: 1727334023070765056
  • Last Price Increase: 2023-12-06

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 22, 2023
  2. changed the title [-]Header-Skeleton is not shown in header while the page is loading[/-] [+][$500] Header-Skeleton is not shown in header while the page is loading[/+] on Nov 22, 2023
  3. melvin-bot commented on Nov 22, 2023

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Nov 22, 2023

    @melvin-bot
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 22, 2023
  6. melvin-bot commented on Nov 22, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Nov 22, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  8. situchan commented on Nov 22, 2023

    @situchan
    Contributor

    @izarutskaya if we already have header info, why should we show skeleton?

  9. abekkala commented on Nov 22, 2023

    @abekkala
    Contributor

    I'm heading out for the Thanksgiving holiday and will be back bright and early Monday morning.
    If something pops up that needs urgent attention please reapply label or ask in slack.

  10. abekkala commented on Nov 27, 2023

    @abekkala
    Contributor

    I believe the fix on this one should resolve here.

  11. melvin-bot commented on Nov 29, 2023

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  12. situchan commented on Nov 29, 2023

    @situchan
    Contributor

    #30362 is different issue

  13. abekkala commented on Nov 29, 2023

    @abekkala
    Contributor

    I'm going to need some clarification here then.
    when watching the 7 second video it appears correct to me.

    I don't know what skeleton UI is that is being referenced. The header seems to look correct to me.

  14. abekkala commented on Dec 4, 2023

    @abekkala
    Contributor

    @izarutskaya can you confirm?

  15. melvin-bot commented on Dec 6, 2023

    @melvin-bot

    @abekkala @situchan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  16. melvin-bot commented on Dec 6, 2023

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  17. abekkala commented on Dec 6, 2023

    @abekkala
    Contributor

    Closing a I'm not seeing a bug here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions