Skip to content

[HOLD for payment 2023-12-14] [$500] Web - Emojis - Flags category is missing on Emoji picker screen #31717

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.2.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to stsaging.new.expensify.com
  2. Navigate to any conversation
  3. Open emoji picker and check emoji categories

Expected Result:

Flags category should be ordered in the list of emoji categories

Actual Result:

Flags category is missing on Emoji picker screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (26)

View all open jobs on GitHub

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 22, 2023
  2. changed the title [-]Web - Emojis - Flags category is missing on Emoji picker screen[/-] [+][$500] Web - Emojis - Flags category is missing on Emoji picker screen[/+] on Nov 22, 2023
  3. melvin-bot commented on Nov 22, 2023

    @melvin-bot

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Nov 22, 2023

    @melvin-bot
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 22, 2023
  6. melvin-bot commented on Nov 22, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Nov 22, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

  8. dummy-1111 commented on Nov 22, 2023

    @dummy-1111
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Flags category is missing in EmojiPicker on Windows web

    What is the root cause of that problem?

    We intentionally disabled the flags category in this PR since Windows doesn't support them.

    What changes do you think we should make in order to solve the problem?

    Now that we have new emoji fonts for Windows, flags are shown as below
    image

    If this is acceptable, we can update the code

    const filteredEmojis =
    getOperatingSystem() === CONST.OS.WINDOWS
    ? EmojiUtils.mergeEmojisWithFrequentlyUsedEmojis(emojiAssets.slice(0, flagHeaderIndex))
    : EmojiUtils.mergeEmojisWithFrequentlyUsedEmojis(emojiAssets);

    to

            const filteredEmojis = EmojiUtils.mergeEmojisWithFrequentlyUsedEmojis(emojiAssets);
    

    What alternative solutions did you explore? (Optional)

  9. aimane-chnaif commented on Nov 23, 2023

    @aimane-chnaif
    Contributor

    This is not worth fixing. Flags are also different.

  10. dummy-1111 commented on Nov 23, 2023

    @dummy-1111
    Contributor

    @aimane-chnaif

    When a iphone user sends a flags emoji to a Windows user, the Windows user is still able to see the flags emoji(as in the screenshot in my proposal).

    A user can receive flags emoji, but can't send flags emoji. I think this is worth fixing

    cc @c3024 @puneetlath

  11. puneetlath commented on Nov 25, 2023

    @puneetlath
    Contributor

    Now that we have new emoji fonts for Windows

    What do you mean by this @s-alves10?

  12. 8 remaining items

  13. c3024 commented on Nov 30, 2023

    @c3024
    Contributor

    Emoji picker missing the section for flags.

  14. shawnborton commented on Nov 30, 2023

    @shawnborton
    Contributor

    Got it. I don't feel too strongly, we already have a flag icon in our library as I thought we already had this section in place. So if we do decide to add it, we at least already have the icon for that section. Might need to make the picker wider on desktop though to account for the extra tab item.

    Curious if @puneetlath thinks this is worth fixing or not though.

  15. puneetlath commented on Dec 1, 2023

    @puneetlath
    Contributor

    I think I'm cool re-adding support for it. It removes some platform specific code and just makes things more consistent, so I say we go for it.

  16. added
    ReviewingHas a PR in review
    and removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 1, 2023
  17. dummy-1111 commented on Dec 2, 2023

    @dummy-1111
    Contributor

    @c3024

    PR is ready for review #32396

  18. dummy-1111 commented on Dec 13, 2023

    @dummy-1111
    Contributor

    Pay day here would be 14 Dec. @puneetlath

  19. puneetlath commented on Dec 13, 2023

    @puneetlath
    Contributor

    Ah thanks. Not sure why the automation didn't work.

    @s-alves10 @c3024 sent you both offers.

  20. changed the title [-][$500] Web - Emojis - Flags category is missing on Emoji picker screen[/-] [+][HOLD for payment 2023-12-14] [$500] Web - Emojis - Flags category is missing on Emoji picker screen[/+] on Dec 13, 2023
  21. dummy-1111 commented on Dec 13, 2023

    @dummy-1111
    Contributor

    @puneetlath Accepted. Thanks

  22. puneetlath commented on Dec 13, 2023

    @puneetlath
    Contributor

    All paid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions