You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-12-14] [$500] Web - Emojis - Flags category is missing on Emoji picker screen #31717
Version Number: 1.4.2.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Go to stsaging.new.expensify.com
Navigate to any conversation
Open emoji picker and check emoji categories
Expected Result:
Flags category should be ordered in the list of emoji categories
Actual Result:
Flags category is missing on Emoji picker screen
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Web - Emojis - Flags category is missing on Emoji picker screen[/-][+][$500] Web - Emojis - Flags category is missing on Emoji picker screen[/+]on Nov 22, 2023
Got it. I don't feel too strongly, we already have a flag icon in our library as I thought we already had this section in place. So if we do decide to add it, we at least already have the icon for that section. Might need to make the picker wider on desktop though to account for the extra tab item.
Curious if @puneetlath thinks this is worth fixing or not though.
changed the title [-][$500] Web - Emojis - Flags category is missing on Emoji picker screen[/-][+][HOLD for payment 2023-12-14] [$500] Web - Emojis - Flags category is missing on Emoji picker screen[/+]on Dec 13, 2023
Activity
[-]Web - Emojis - Flags category is missing on Emoji picker screen[/-][+][$500] Web - Emojis - Flags category is missing on Emoji picker screen[/+]melvin-bot commentedon Nov 22, 2023
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 22, 2023
Job added to Upwork: https://www.upwork.com/jobs/~012c3f161bd9db1ab3
melvin-bot commentedon Nov 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Nov 22, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (
External)dummy-1111 commentedon Nov 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Flags category is missing in EmojiPicker on Windows web
What is the root cause of that problem?
We intentionally disabled the flags category in this PR since Windows doesn't support them.
What changes do you think we should make in order to solve the problem?
Now that we have new emoji fonts for Windows, flags are shown as below

If this is acceptable, we can update the code
App/src/components/EmojiPicker/EmojiPickerMenu/index.js
Lines 76 to 79 in 704f3f7
to
What alternative solutions did you explore? (Optional)
aimane-chnaif commentedon Nov 23, 2023
This is not worth fixing. Flags are also different.
dummy-1111 commentedon Nov 23, 2023
@aimane-chnaif
When a iphone user sends a flags emoji to a Windows user, the Windows user is still able to see the flags emoji(as in the screenshot in my proposal).
A user can receive flags emoji, but can't send flags emoji. I think this is worth fixing
cc @c3024 @puneetlath
puneetlath commentedon Nov 25, 2023
What do you mean by this @s-alves10?
8 remaining items
c3024 commentedon Nov 30, 2023
Emoji picker missing the section for flags.
shawnborton commentedon Nov 30, 2023
Got it. I don't feel too strongly, we already have a flag icon in our library as I thought we already had this section in place. So if we do decide to add it, we at least already have the icon for that section. Might need to make the picker wider on desktop though to account for the extra tab item.
Curious if @puneetlath thinks this is worth fixing or not though.
puneetlath commentedon Dec 1, 2023
I think I'm cool re-adding support for it. It removes some platform specific code and just makes things more consistent, so I say we go for it.
dummy-1111 commentedon Dec 2, 2023
@c3024
PR is ready for review #32396
dummy-1111 commentedon Dec 13, 2023
Pay day here would be 14 Dec. @puneetlath
puneetlath commentedon Dec 13, 2023
Ah thanks. Not sure why the automation didn't work.
@s-alves10 @c3024 sent you both offers.
[-][$500] Web - Emojis - Flags category is missing on Emoji picker screen[/-][+][HOLD for payment 2023-12-14] [$500] Web - Emojis - Flags category is missing on Emoji picker screen[/+]dummy-1111 commentedon Dec 13, 2023
@puneetlath Accepted. Thanks
puneetlath commentedon Dec 13, 2023
All paid.