Skip to content

[HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Wallet - App crashes when selecting Wallet > Add bank account > Business bank account #31797

New issue
New issue
Closed
Closed
[HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Wallet - App crashes when selecting Wallet > Add bank account > Business bank account#31797
Assignees
luacmartinshayata-suenaga
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Engineering

Description

@kbecciv
kbecciv
opened on Nov 23, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.3.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open App or go to staging.new.expensify.com
  2. Login with gmail account
  3. Go to Settings > Wallet > Add bank account > Business bank account

Expected Result:

User can continue connecting the bank account

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6288925_1700770710020.Desktop-Crash-Wallet-BA.mp4

View all open jobs on GitHub

Activity

  1. kbecciv
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 23, 2023
  2. github-actions
    added
    Engineering
    HourlyKSv2
    on Nov 23, 2023

  3. github-actions commented on Nov 23, 2023

    @github-actions
    github-actionsBot
    on Nov 23, 2023 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  4. melvin-bot commented on Nov 23, 2023

    @melvin-bot
    melvin-botBot
    on Nov 23, 2023 – with Melvin Bot

    📣 @github-actions[bot]! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
  5. melvin-bot
    assigned
    hayata-suenaga
    on Nov 23, 2023

  6. melvin-bot commented on Nov 23, 2023

    @melvin-bot
    melvin-botBot
    on Nov 23, 2023 – with Melvin Bot

    Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. situchan commented on Nov 23, 2023

    @situchan
    situchan
    on Nov 23, 2023
    Contributor

    Commented on offending PR - https://github.com/Expensify/App/pull/30582/files#r1403715597

  8. hayata-suenaga commented on Nov 23, 2023

    @hayata-suenaga
    hayata-suenaga
    on Nov 23, 2023
    Contributor

    @situchan do you have a solution for this?

  9. situchan commented on Nov 23, 2023

    @situchan
    situchan
    on Nov 23, 2023
    Contributor

    I am not sure about the expected behavior.
    What should show when click "Business bank account"? Or just hide that menu for now? Seems like WIP
    cc: @mountiny

  10. luacmartins commented on Nov 23, 2023

    @luacmartins
    luacmartins
    on Nov 23, 2023
    Contributor

    From that PR's OP:

    choose to pay p2p IOU report with business bank account

    So it seems like we need to start allowing that payment method and launching the VBBA setup

  11. luacmartins commented on Nov 23, 2023

    @luacmartins
    luacmartins
    on Nov 23, 2023
    Contributor

    I'm not sure how to handle that from the wallet page because in NewDot we tie the bank account to a specific policy (we have this issue to fix that). Maybe in the meantime we just select a random policy the user has stored?

  12. mountiny commented on Nov 23, 2023

    @mountiny
    mountiny
    on Nov 23, 2023
    Contributor

    In this case we should just normally open the BBA flow, I havent tested this flow before

  13. luacmartins commented on Nov 23, 2023

    @luacmartins
    luacmartins
    on Nov 23, 2023
    Contributor

    Ok, I'll put up a PR to fix it

  14. luacmartins
    self-assigned this
    on Nov 23, 2023

  15. 7 remaining items

  16. melvin-bot
    added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Nov 27, 2023
  17. melvin-bot
    changed the title [-]Wallet - App crashes when selecting Wallet > Add bank account > Business bank account[/-] [+][HOLD for payment 2023-12-04] Wallet - App crashes when selecting Wallet > Add bank account > Business bank account[/+] on Nov 27, 2023
  18. melvin-bot
    removed
    ReviewingHas a PR in review
    on Nov 27, 2023

  19. melvin-bot commented on Nov 27, 2023

    @melvin-bot
    melvin-botBot
    on Nov 27, 2023 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  20. melvin-bot commented on Nov 27, 2023

    @melvin-bot
    melvin-botBot
    on Nov 27, 2023 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-04. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
  21. melvin-bot
    added
    WeeklyKSv2
    and removed
    WeeklyKSv2
    on Nov 29, 2023
  22. melvin-bot
    changed the title [-][HOLD for payment 2023-12-04] Wallet - App crashes when selecting Wallet > Add bank account > Business bank account[/-] [+][HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Wallet - App crashes when selecting Wallet > Add bank account > Business bank account[/+] on Nov 29, 2023

  23. melvin-bot commented on Nov 29, 2023

    @melvin-bot
    melvin-botBot
    on Nov 29, 2023 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-06. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
  24. melvin-bot
    added
    DailyKSv2
    Overdue
    and removed
    WeeklyKSv2
    on Dec 3, 2023

  25. luacmartins commented on Dec 6, 2023

    @luacmartins
    luacmartins
    on Dec 6, 2023
    Contributor

    No payment is due here. We're good to close.

  26. luacmartins
    closed this as completedon Dec 6, 2023
  27. melvin-bot
    removed
    Overdue
    on Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions