Skip to content

[$500] [HOLD for payment 2023-12-06] Chat - Encountering a duplicate 'Pay with Expensify' option when the admin opens the dropdown #31829

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.3.2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #30582

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create 2 accounts, one will be used as employee and second as an admin
  3. Request 1:1 money as employee from the admin
  4. As admin, go to the 1:1 chat and click Pay With Expensify

Expected Result:

The 'Pay with Expensify' option should be visible only once when the admin opens the dropdown.

Actual Result:

Encountering a duplicate 'Pay with Expensify' option when the admin opens the dropdown

Workaround:

Unknonw

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (27)

Recording.5518.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @kadiealexander
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01878c6382f2f8f9a9
  • Upwork Job ID: 1732610039305871360
  • Last Price Increase: 2023-12-07

Activity

  1. melvin-bot commented on Nov 24, 2023

    @melvin-bot

    Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. raphaelppp commented on Nov 24, 2023

    @raphaelppp

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The button to settle with a verified bank account is mislabeled as "settle with expensify".

    What is the root cause of that problem?

    The button to settle with a verified bank account is mislabeled as "settle with expensify".

    What changes do you think we should make in order to solve the problem?

    Changed the label of the button by adding a new localization key.

  3. mountiny commented on Nov 24, 2023

    @mountiny
    Contributor

    I cannot repro on main
    image

  4. mountiny commented on Nov 24, 2023

    @mountiny
    Contributor

    I cannot repro in staging either
    image

  5. raphaelppp commented on Nov 24, 2023

    @raphaelppp

    @mountiny
    Your currency must be USD.

  6. mountiny commented on Nov 24, 2023

    @mountiny
    Contributor

    I still cannot repro if I use USD and VPN in the US

  7. kavimuru commented on Nov 24, 2023

    @kavimuru

    @vit I am still able to reproduce.

    image

  8. mountiny commented on Nov 24, 2023

    @mountiny
    Contributor

    ok yeah the report needs to be on USD

  9. 25 remaining items

  10. kadiealexander commented on Dec 6, 2023

    @kadiealexander
    Contributor

    Hey @situchan, could you please sort the bugzero checklist?

  11. situchan commented on Dec 6, 2023

    @situchan
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Create v1 Collect workspace Bottom Up flow #30582
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30582/files#r1416698670
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug. N/A as caught by Applause during PR test
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  12. changed the title [-][HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Chat - Encountering a duplicate 'Pay with Expensify' option when the admin opens the dropdown[/-] [+][HOLD for payment 2023-12-06] Chat - Encountering a duplicate 'Pay with Expensify' option when the admin opens the dropdown[/+] on Dec 6, 2023
  13. kadiealexander commented on Dec 7, 2023

    @kadiealexander
    Contributor

    Hey @situchan are you paid via Upwork or Newdot?

  14. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 7, 2023
  15. changed the title [-][HOLD for payment 2023-12-06] Chat - Encountering a duplicate 'Pay with Expensify' option when the admin opens the dropdown[/-] [+][$500] [HOLD for payment 2023-12-06] Chat - Encountering a duplicate 'Pay with Expensify' option when the admin opens the dropdown[/+] on Dec 7, 2023
  16. melvin-bot commented on Dec 7, 2023

    @melvin-bot
  17. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 7, 2023
  18. melvin-bot commented on Dec 7, 2023

    @melvin-bot

    Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

  19. situchan commented on Dec 7, 2023

    @situchan
    Contributor

    Hey @situchan are you paid via Upwork or Newdot?

    Upwork please

  20. kadiealexander commented on Dec 7, 2023

    @kadiealexander
    Contributor

    Roger, sent you a contract!

  21. kadiealexander commented on Dec 7, 2023

    @kadiealexander
    Contributor

    Payouts due:

    Upwork job is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions