[HOLD for payment 2023-12-29] [TS migration] Migrate 'IFrame.js' component to TypeScript

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/IFrame.js	4

I am Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this job!

@marcaaron

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@marcaaron

hi @marcaaron , can you help to:

Assign me to this issue
Add the issue label "New Feature" or "Bug" to trigger adding a BZ member to this issue
Thanks

Reviewing label has been removed, please complete the "BugZero Checklist".

@hoangzinh

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[TS migration] Migrate 'IFrame.js' component to TypeScript #32199

If no regressions arise, payment will be issued on 2023-12-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@hoangzinh requires payment (Needs manual offer from BZ)
@pac-guerreiro does not require payment (Contractor)

@hoangzinh

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
[@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hoangzinh] Determine if we should create a regression test for this bug.
[@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@pac-guerreiro

Payment Summary:

Contributor: @pac-guerreiro is from an agency-contributor and not due payment.
Contributor+: @hoangzinh is due $250 here: https://www.upwork.com/nx/wm/offer/100263336

@twisterdotcom

Accepted. Thanks @twisterdotcom

All paid out.

Navigation Menu

Repository navigation

[HOLD for payment 2023-12-29] [TS migration] Migrate 'IFrame.js' component to TypeScript #31932

TypeScript migration

Files

10 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-12-29] [TS migration] Migrate 'IFrame.js' component to TypeScript #31932

Description

TypeScript migration

Files

Activity

pac-guerreiro commented on Nov 29, 2023

melvin-bot commented on Dec 18, 2023

hoangzinh commented on Dec 20, 2023

10 remaining items

melvin-bot commented on Dec 22, 2023

melvin-bot commented on Dec 22, 2023

melvin-bot commented on Dec 22, 2023

twisterdotcom commented on Jan 2, 2024

hoangzinh commented on Jan 2, 2024

twisterdotcom commented on Jan 2, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions