Skip to content

[HOLD for payment 2024-02-26] [TS migration] Migrate 'EditSplitBill' page to TypeScript #31990

Closed

Description

@melvin-bot

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/EditSplitBillPage.js 18

Activity

  1. melvin-bot commented on Dec 21, 2023

    @melvin-bot
    Author

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  2. SzymczakJ commented on Jan 23, 2024

    @SzymczakJ
    Contributor

    Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

  3. melvin-bot commented on Feb 13, 2024

    @melvin-bot
    Author

    Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  4. 14 remaining items

  5. changed the title [-][TS migration] Migrate 'EditSplitBill' page to TypeScript[/-] [+][HOLD for payment 2024-02-26] [TS migration] Migrate 'EditSplitBill' page to TypeScript[/+] on Feb 19, 2024
  6. melvin-bot commented on Feb 19, 2024

    @melvin-bot
    Author

    Reviewing label has been removed, please complete the "BugZero Checklist".

  7. melvin-bot commented on Feb 19, 2024

    @melvin-bot
    Author

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-26. 🎊

    For reference, here are some details about the assignees on this issue:

    • @jjcoffee requires payment (Needs manual offer from BZ)
    • @SzymczakJ does not require payment (Contractor)
  8. melvin-bot commented on Feb 19, 2024

    @melvin-bot
    Author

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
    • [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@jjcoffee] Determine if we should create a regression test for this bug.
    • [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  9. melvin-bot commented on Feb 26, 2024

    @melvin-bot
    Author

    Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  10. melvin-bot commented on Feb 26, 2024

    @melvin-bot
    Author

    Payment Summary

    Upwork Job

    • C+: @jjcoffee paid $250 via Upwork here
    • Contributor: @SzymczakJ is from an agency-contributor and not due payment

    BugZero Checklist (@twisterdotcom)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. twisterdotcom commented on Feb 27, 2024

    @twisterdotcom
    Contributor

    Awaiting acceptance of offer from @jjcoffee

  12. jjcoffee commented on Feb 27, 2024

    @jjcoffee
    Contributor

    @twisterdotcom Accepted, thank you!

  13. twisterdotcom commented on Feb 27, 2024

    @twisterdotcom
    Contributor

    Paid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2TaskTypescript Migration

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions