Skip to content

[$125] [Form Provider Refactor] AddressForm #32064

Closed

Description

@luacmartins

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/components/AddressForm.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d9d14f0105c78b4c
  • Upwork Job ID: 1729190075497373696
  • Last Price Increase: 2023-11-29
Issue OwnerCurrent Issue Owner: @cdOut

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 27, 2023
  2. self-assigned this
    on Nov 27, 2023
  3. melvin-bot commented on Nov 27, 2023

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Nov 27, 2023

    @melvin-bot
  5. added
    InternalRequires API changes or must be handled by Expensify staff
    on Nov 27, 2023
  6. melvin-bot commented on Nov 27, 2023

    @melvin-bot
  7. melvin-bot commented on Nov 27, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @Ollyws (Internal)

  8. cdOut commented on Nov 29, 2023

    @cdOut
    Contributor

    Hello, I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency and I would like to work on this task.

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    InternalRequires API changes or must be handled by Expensify staff
    on Nov 29, 2023
  10. changed the title [-][Form Provider Refactor] AddressForm[/-] [+][$500] [Form Provider Refactor] AddressForm[/+] on Nov 29, 2023
  11. 15 remaining items

  12. cdOut commented on Dec 7, 2023

    @cdOut
    Contributor

    @zanyrenney PR currently waiting for review

  13. melvin-bot commented on Jan 1, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @Ollyws, @luacmartins, @zanyrenney, @cdOut eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  14. cdOut commented on Jan 2, 2024

    @cdOut
    Contributor

    This is completed and merged.

  15. zanyrenney commented on Jan 23, 2024

    @zanyrenney
    Contributor

    As SWM contributor, closing as payment not handled here! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions