Repository navigation
[LOW] [Splits] [$500] Web - IOU is greyed out, error message appears in chat and console #32076
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.4.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #31102
Action Performed:
- Navigate to https://staging.new.expensify.com/
- Log in with a new account
- Start a chat using the FAB
- Input an account who isn't registered yet
- Send a message
- Upload a picture using the composers "+" button
- Request money (manual) using the FAB
- Input an email (can be the one from step 4 or a new one)
- Finish the IOU
Expected Result:
I should be able to make the IOU without error messages or console errors
Actual Result:
I get an error message and the IOU is greyed out. Two errors appear in the console as soon as the error message appears in the chat
Unexpected error creating this chat, please try again later. There is a previously existing chat between these users
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- Windows: Chrome
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6292386_1701121325770.bandicam_2023-11-27_21-33-01-176.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01ae5fe97cb4eccf95
- Upwork Job ID: 1729285304604618752
- Last Price Increase: 2023-11-27
Activity
[-]IOU - IOU is greyed out, errror message appears in chat and console[/-][+][$500] IOU - IOU is greyed out, errror message appears in chat and console[/+]melvin-bot commentedon Nov 27, 2023
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 27, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01ae5fe97cb4eccf95
melvin-bot commentedon Nov 27, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Nov 27, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (
External)tienifr commentedon Nov 28, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
When creating IOU with users we already have chat with, get error "Unexpected error creating this chat, please try again later. There is a previously existing chat between these users"
What is the root cause of that problem?
We're not handling the preexisting chat case properly for the IOU case. The proper way to handle it is to redirect to the preexisting chat and clear the unnecessary data here, which already works fine in case of
New chatcreated that has preexisting chat.What changes do you think we should make in order to solve the problem?
RequestMoneycommand, the back-end should returnpreexistingReportID(similar toOpenReport) if the report creation failure is due to existing report between the 2 users. It should also handle so that the money request is created properly on that preexisting reportWhat alternative solutions did you explore? (Optional)
Other related flow like split bill might have the same issue, we'll need to double check and fix for them as well.
narefyev91 commentedon Nov 28, 2023
Proposal from @tienifr looks good to me #32076 (comment)
🎀 👀 🎀 C+ reviewed
melvin-bot commentedon Nov 28, 2023
Triggered auto assignment to @iwiznia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
112 remaining items
iwiznia commentedon Apr 24, 2024
No update
iwiznia commentedon May 27, 2024
No update
iwiznia commentedon Jul 2, 2024
No update
parasharrajat commentedon Aug 4, 2024
@joekaufmanexpensify Let's push this forward to the finish line. Is there a reason to hold this issue? Please change the label to weekly.
joekaufmanexpensify commentedon Aug 5, 2024
Hm, I don't think it is explicitly on hold. It's a question of internal priorities, given the next step here is for @iwiznia to put up the backend fix discussed here. Defer to him on when he thinks he'll be able to prioritize it. Happy to move it to weekly if that will be soon.
parasharrajat commentedon Aug 5, 2024
It's been almost 8 months. Let's get this prioritized now. What do you think @iwiznia?
iwiznia commentedon Aug 12, 2024
The changes needed are quite large and involve lots of api commands... given the low severity of the issues and the fact that reproduction steps are quite complex, I think we might be better off closing it.