[HOLD for payment 2024-01-25] [$500] Web - "Bank account" option does not appear in "Wallet"

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.4.-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32079

Action Performed:

Go to settings > wallet
Add bank account

Expected Result:

Bank account option appears

Actual Result:

Only debit card option appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ea0db427c9d793c6
Upwork Job ID: 1729294846848581632
Last Price Increase: 2023-12-12

@muttmuure

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~01ea0db427c9d793c6

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@aimane-chnaif

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

Is there a reason why this error doesn't occur in dev, but does occur in staging?

Proposal

Please re-state the problem that we are trying to solve in this issue.

Only debit card option appears

What is the root cause of that problem?

We're only showing Personal bank account if we can validate the IOU report passed in, based on this condition. In Wallet page, there'll be no IOU report passed in so canUseBusinessBankAccount is always false.

What changes do you think we should make in order to solve the problem?

Always show Personal bank account if the AddPaymentMethodMenu is from WalletPage. This can be done by updating the canUsePersonalBankAccount check to:

Check if iouReport is empty, if yes always show Personal bank account, only if it's not empty, we'll check other conditions related to the iouReport

isEmpty(iouReport) ||
...rest

Or use a new prop to indicate it's from wallet page, or more precisely from non-IOU flow

Update: The prop I mentioned has been added via this PR so we can just use it

What alternative solutions did you explore? (Optional)

NA

Contributor details
Your Expensify account email: semenovihor95@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0132b61da48807943c

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Created a payment issue

Paid up

@muttmuure

Created a payment issue

Hi @muttmuure would you mind linking the issue/Upwork job you created for payment?

Somehow I haven't been able to find it.

Thanks!

@muttmuure

Hi @muttmuure would you mind linking the issue/Upwork job you created for payment?

@muttmuure Bump on this, thanks!

@tienifr

So sorry @tienifr! I must have not completed the full payment steps or hit an error. I have sent you a new offer

@tienifr

Thanks for looking into this!

So sorry @tienifr! I must have not completed the full payment steps or hit an error. I have sent you a new offer

I've submitted a proposal to the Upwork invitation you sent!

@muttmuure

@muttmuure Could we proceed with next step here?

Thanks!

Sorry, not sure what happened there. Anyway, everyone has been paid.

Navigation Menu

Repository navigation

[HOLD for payment 2024-01-25] [$500] Web - "Bank account" option does not appear in "Wallet" #32079

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

79 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-01-25] [$500] Web - "Bank account" option does not appear in "Wallet" #32079

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 28, 2023

melvin-bot commented on Nov 28, 2023

melvin-bot commented on Nov 28, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Nov 28, 2023

jgddesigns commented on Nov 28, 2023

tienifr commented on Nov 28, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

kouhei007 commented on Nov 28, 2023

melvin-bot commented on Nov 28, 2023

79 remaining items

muttmuure commented on Jan 29, 2024

muttmuure commented on Feb 6, 2024

tienifr commented on Feb 29, 2024

tienifr commented on Mar 18, 2024

muttmuure commented on Mar 19, 2024

tienifr commented on Mar 20, 2024

tienifr commented on Mar 26, 2024

muttmuure commented on Apr 9, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions