Skip to content

[HOLD for payment 2023-12-08] [HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] [$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question #32104

New issue
New issue
Closed
Closed
[HOLD for payment 2023-12-08] [HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] [$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question#32104
Assignees
madmax330abekkalaluacmartins
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in reviewWeeklyKSv2

Description

@izarutskaya
izarutskaya
opened on Nov 28, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Found when executing PR: #31401

Version Number: v1.4.4-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any expensifail account
  3. Go to Settings -> Wallet -> Enable Wallet
  4. Follow the flow until your reach the "Additional details" page
  5. Fill the form with following data: First name: Alberta, Last name: Bobbeth, SSN: 1234, Any other information for the rest of the fields
  6. Tap on "Save & continue"
  7. Change the SSN for 123456789 -> Tap on "Save & continue"
  8. Idology questions should appear
  9. Don't fill anything and press Save & continue -> Errors should appear
  10. Select any response -> Tap on "Save & continue"
  11. Don't fill anything for second question and press Save & continue

Expected Result:

Errors should appear when pressing Save&Continue without filling anything in all idology questions

Actual Result:

No error message when press Save&Continue without filling anything in 2 and next idology question

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6292867_1701162387966.bandicam_2023-11-28_10-54-49-442.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01645371315accf60d
  • Upwork Job ID: 1729462498357043200
  • Last Price Increase: 2023-11-28

Activity

  1. izarutskaya
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 28, 2023
  2. melvin-bot
    changed the title [-]Web-No error message if press Save&Continue without fill anything in 2 & next idology question[/-] [+][$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question[/+] on Nov 28, 2023

  3. melvin-bot commented on Nov 28, 2023

    @melvin-bot
    melvin-botBot
    on Nov 28, 2023 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~01645371315accf60d

  4. melvin-bot
    assigned
    abekkala
    on Nov 28, 2023

  5. melvin-bot commented on Nov 28, 2023

    @melvin-bot
    melvin-botBot
    on Nov 28, 2023 – with Melvin Bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 28, 2023

  7. melvin-bot commented on Nov 28, 2023

    @melvin-bot
    melvin-botBot
    on Nov 28, 2023 – with Melvin Bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

  8. melvin-bot commented on Nov 28, 2023

    @melvin-bot
    melvin-botBot
    on Nov 28, 2023 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

  9. melvin-bot
    assigned
    c3024
    on Nov 28, 2023
  10. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 28, 2023
  11. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Nov 28, 2023

  12. 31 remaining items

  13. melvin-bot
    added
    WeeklyKSv2
    and removed
    WeeklyKSv2
    on Nov 30, 2023
  14. melvin-bot
    changed the title [-][HOLD for payment 2023-12-06] [$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question[/-] [+][HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] [$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question[/+] on Nov 30, 2023
  15. melvin-bot
    removed
    ReviewingHas a PR in review
    on Nov 30, 2023

  16. melvin-bot commented on Nov 30, 2023

    @melvin-bot
    melvin-botBot
    on Nov 30, 2023 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Nov 30, 2023

    @melvin-bot
    melvin-botBot
    on Nov 30, 2023 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-07. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

  18. melvin-bot commented on Nov 30, 2023

    @melvin-bot
    melvin-botBot
    on Nov 30, 2023 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@madmax330 / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
    • [@madmax330 / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@madmax330 / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@madmax330 / @luacmartins] Determine if we should create a regression test for this bug.
    • [@madmax330 / @luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  19. melvin-bot
    added
    WeeklyKSv2
    and removed
    WeeklyKSv2
    on Dec 1, 2023
  20. melvin-bot
    changed the title [-][HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] [$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question[/-] [+][HOLD for payment 2023-12-08] [HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] [$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question[/+] on Dec 1, 2023

  21. melvin-bot commented on Dec 1, 2023

    @melvin-bot
    melvin-botBot
    on Dec 1, 2023 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-08. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

  22. melvin-bot commented on Dec 1, 2023

    @melvin-bot
    melvin-botBot
    on Dec 1, 2023 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@madmax330 / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
    • [@madmax330 / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@madmax330 / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@madmax330 / @luacmartins] Determine if we should create a regression test for this bug.
    • [@madmax330 / @luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  23. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    WeeklyKSv2
    on Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions