Skip to content

[$500] Bank account - User is redirected to BA page when paying with Expensify and BA is set up #32112

New issue
New issue
Closed
Closed
[$500] Bank account - User is redirected to BA page when paying with Expensify and BA is set up#32112
Assignees
johnmlee101fedirjhmuttmuurerezkiy37
Labels
BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@kbecciv
kbecciv
opened on Nov 28, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.4.0
Reproducible in staging?: y
Reproducible in production?: cannot check the production
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: Workspace has a Chase bank account set up via Connect online with Plaid method.

  1. Go to the workspace chat.
  2. Create a workspace expense (Manual).
  3. Click Pay with Expensify.
  4. Click Business bank account.

Expected Result:

User will be redirected to the next payment step.

Actual Result:

User is redirected to workspace bank account page although the bank account is already set up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6293161_1701176443844.20231128_135303.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cb3238d2b83fb332
  • Upwork Job ID: 1729823536743481344
  • Last Price Increase: 2024-02-07
  • Automatic offers:
    • fedirjh | Reviewer | 0
Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. kbecciv
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 28, 2023
  2. github-actions
    added
    Engineering
    HourlyKSv2
    on Nov 28, 2023

  3. github-actions commented on Nov 28, 2023

    @github-actions
    github-actionsBot
    on Nov 28, 2023 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot
    assigned
    johnmlee101
    on Nov 28, 2023

  5. melvin-bot commented on Nov 28, 2023

    @melvin-bot
    melvin-botBot
    on Nov 28, 2023 – with Melvin Bot

    Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. johnmlee101 commented on Nov 28, 2023

    @johnmlee101
    johnmlee101
    on Nov 28, 2023
    Contributor

    Hmm all of our code regarding the business bank account refers to setup in our code.

    App/src/components/AddPaymentMethodMenu.js

    Line 98 in a137813

    onSelected: () => onItemSelected(CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT),

    App/src/components/KYCWall/BaseKYCWall.js

    Line 102 in 23dda79

    } else if (paymentMethod === CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT) {

    App/src/pages/settings/Wallet/WalletPage/WalletPage.js

    Line 204 in 1163dc3

    @flodnv it looks like you changed this code most recently however, curious on your thoughts. Maybe this shouldn't be a blocker yet

  7. johnmlee101 commented on Nov 28, 2023

    @johnmlee101
    johnmlee101
    on Nov 28, 2023
    Contributor

    #31784 PR that added this option

  8. johnmlee101 commented on Nov 28, 2023

    @johnmlee101
    johnmlee101
    on Nov 28, 2023
    Contributor

    Actually this was the commit I was looking at: e564ecc

  9. johnmlee101 commented on Nov 28, 2023

    @johnmlee101
    johnmlee101
    on Nov 28, 2023
    Contributor

    @mountiny https://github.com/Expensify/App/pull/30582/files#diff-8c06fd96ed7306e88ac43532f2b2cdbc6a46c9914847c6d9f4c14c45af7f36cbR92 I think it originated from the addition here?

  10. mountiny commented on Nov 28, 2023

    @mountiny
    mountiny
    on Nov 28, 2023
    Contributor

    Discussing in slack

  11. johnmlee101
    added
    DailyKSv2
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Nov 28, 2023

  12. johnmlee101 commented on Nov 28, 2023

    @johnmlee101
    johnmlee101
    on Nov 28, 2023
    Contributor

    Demoting this since its a very edge-case flow we're debugging, and it requires more time to investigate- but we won't need to block on it

  13. 94 remaining items

  14. hayata-suenaga commented on Feb 21, 2024

    @hayata-suenaga
    hayata-suenaga
    on Feb 21, 2024
    Contributor

    @rezkiy37 can you test this on staging? if the staging fails and it works on main, maybe some recent PR fixed it.

  15. rezkiy37 commented on Feb 22, 2024

    @rezkiy37
    rezkiy37
    on Feb 22, 2024
    Contributor

    @hayata-suenaga, just tested on staging on the same account and workspace. It works properly.

    Staging.mp4

  16. hayata-suenaga commented on Feb 22, 2024

    @hayata-suenaga
    hayata-suenaga
    on Feb 22, 2024
    Contributor

    as this issue is not reproducible, I'm closing this issue

  17. hayata-suenaga
    closed this as completedon Feb 22, 2024
  18. melvin-bot
    removed
    Overdue
    on Feb 22, 2024

  19. lanitochka17 commented on Mar 18, 2024

    @lanitochka17
    lanitochka17
    on Mar 18, 2024

    Issue is still reproducible on the latest build 1.4.53-2

    bandicam.2024-03-18.21-39-07-700.mp4
  20. lanitochka17
    reopened this on Mar 18, 2024

  21. hayata-suenaga commented on Mar 18, 2024

    @hayata-suenaga
    hayata-suenaga
    on Mar 18, 2024
    Contributor

    @rezkiy37 @fedirjh could you check back this issue and what step we need to take next? 🙇

  22. muttmuure
    added this to [#whatsnext] #wave-collecton Mar 19, 2024
  23. melvin-bot
    added
    Overdue
    on Mar 25, 2024

  24. rezkiy37 commented on Mar 25, 2024

    @rezkiy37
    rezkiy37
    on Mar 25, 2024
    Contributor

    I've tried to reproduce with the same account and configs I had before. I cannot see the problem.

    Bank.mp4

  25. hayata-suenaga commented on Mar 25, 2024

    @hayata-suenaga
    hayata-suenaga
    on Mar 25, 2024
    Contributor

    seems like this is not reproducible anymore. closing this issue

    thank you for checking @rezkiy37

  26. hayata-suenaga
    closed this as completedon Mar 25, 2024
  27. melvin-bot
    removed
    Overdue
    on Mar 25, 2024
  28. github-project-automation
    moved this to Done in [#whatsnext] #wave-collecton Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions