[$500] Wallet - Radio buttons in questionnaire page have a different design

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.4.0
Reproducible in staging?: y
Reproducible in production?: cannot check production
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31050

Action Performed:

Precondition: User has added a bank account.

Navigate to staging.new.expensify.com
Go to Settings > Wallet > Enable wallet.
Proceed to questionnaire page.

Expected Result:

The radio button has a tick in the button when unchecked and has green background when selected (Please refer to PR attachment).

Actual Result:

The radio button does not have a tick in the button when unchecked and does not have a green background when checked (different radio button from PR).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Staging

PR

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f3dc5fe1ec3e1343
Upwork Job ID: 1729517232411906048
Last Price Increase: 2023-12-05

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@Julesssss

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@miljakljajic

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wallet - Radio buttons in questionnaire page have a different design

What is the root cause of that problem?

I don't know why this is a bug
Because these styles are used within RadioButton component
And these changes couldn't be change just like that

What changes do you think we should make in order to solve the problem?

We can update styles like

            <View style={[styles.radioButtonContainer, isChecked && styles.checkedContainer, hasError && styles.borderColorDanger, disabled && styles.cursorDisabled]}>
                <Icon
                    src={Expensicons.Checkmark}
                    fill={theme.white}
                    height={14}
                    width={14}
                />
            </View>
        </PressableWithFeedback>

App/src/components/RadioButton.tsx

Lines 40 to 50 in 5eea628

    
               <View style={[styles.radioButtonContainer, hasError && styles.borderColorDanger, disabled && styles.cursorDisabled]}> 
        
                   {isChecked && ( 
        
                       <Icon 
        
                           src={Expensicons.Checkmark} 
        
                           fill={theme.checkBox} 
        
                           height={14} 
        
                           width={14} 
        
                       /> 
        
                   )} 
        
               </View> 
        
           </PressableWithFeedback>

Plus other changes from PR ↓

What alternative solutions did you explore? (Optional)

NA

#30791

I found )
That's where the changes were
Looks like something expected
But we can always revert the changes

@dangrous

@dangrous @nkuoch Confirming that did we intentionally change the radio button design?

@dubielzyk-expensify

Yep! Staging is correct, this is an intentional update - to double check cc @dubielzyk-expensify but I think we're good

Looks good to me!

So this is expected? Should we close?

@miljakljajic

Yes @miljakljajic we should close this one out.

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Navigation Menu

Repository navigation

[$500] Wallet - Radio buttons in questionnaire page have a different design #32119

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

7 remaining items

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<View style={[styles.radioButtonContainer, hasError && styles.borderColorDanger, disabled && styles.cursorDisabled]}>
	{isChecked && (
	<Icon
	src={Expensicons.Checkmark}
	fill={theme.checkBox}
	height={14}
	width={14}
	/>
	)}
	</View>
	</PressableWithFeedback>

[$500] Wallet - Radio buttons in questionnaire page have a different design #32119

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Nov 28, 2023

melvin-bot commented on Nov 28, 2023

7 remaining items

melvin-bot commented on Nov 28, 2023

melvin-bot commented on Nov 28, 2023

Bug0 Triage Checklist (Main S/O)

ZhenjaHorbach commented on Nov 28, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ZhenjaHorbach commented on Nov 28, 2023

mananjadhav commented on Nov 30, 2023

dangrous commented on Nov 30, 2023

dubielzyk-expensify commented on Dec 4, 2023

miljakljajic commented on Dec 4, 2023

mananjadhav commented on Dec 4, 2023

melvin-bot commented on Dec 5, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions