You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-09] [Wave 6: Drafts] Make Merchant field required for requests on group policies #32222
The Merchant field is required value for expenses in database, thats why we have been always setting the Request name for all IOU or Expense requests for now. This however does not scale well for more business usecases so we should copy what we do in OldDot and make sure the merchant is required to be filled out by the user on group policies. (Free, Collect, Corporate) ie any expense report
Solution
Show a form error if you try to create a manual request without a merchant on Group plans, remove the default
ie users should not be able to create new requests on Group policies without supplying Merchant
this holds for manual requests, receipts get smartscanned and distance requests have predefined merchant fields
Splitting a manual bill with Group policy is also cannot be done without supplying merchant
changed the title [-][Drafts] Make Merchant field required for requests on paid policies[/-][+][Drafts] Make Merchant field required for requests on group policies[/+]on Nov 30, 2023
changed the title [-][Wave 6: Drafts] Make Merchant field required for requests on group policies[/-][+][HOLD for payment 2024-01-09] [Wave 6: Drafts] Make Merchant field required for requests on group policies[/+]on Jan 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.20-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-09. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@waterim] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@abekkala / @sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon Nov 29, 2023
Triggered auto assignment to @abekkala (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.[-][Drafts] Make Merchant field required for requests on paid policies[/-][+][Drafts] Make Merchant field required for requests on group policies[/+]waterim commentedon Nov 30, 2023
Hello, Im Artem from Callstack and would like to help with this issue
12 remaining items
[-][Wave 6: Drafts] Make Merchant field required for requests on group policies[/-][+][HOLD for payment 2024-01-09] [Wave 6: Drafts] Make Merchant field required for requests on group policies[/+]melvin-bot commentedon Jan 2, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.20-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-09. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 2, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Jan 9, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
mountiny commentedon Jan 9, 2024
I think this can be closed now