[HOLD for payment 2023-12-28] [$500] Send money - Bank account option is not present in Pay with Expensify menu

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.5-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go to 1:1 DM
Click + > Send money
Select USD currency and enter an amount > Click Next
Click Pay with Expensify

Expected Result:

Bank account option will be present in Pay with Expensify menu

Actual Result:

Bank account option is not present in Pay with Expensify menu

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6295100_1701288930404.bandicam_2023-11-30_03-10-17-567.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01782e16325ea5e0f2
Upwork Job ID: 1729983421600763904
Last Price Increase: 2023-11-29
Automatic offers:

aimane-chnaif | Reviewer | 27911758
dukenv0307 | Contributor | 27911760

Issue Owner

Current Issue Owner: @trjExpensify

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~01782e16325ea5e0f2

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@aimane-chnaif

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

In SettlementButton in the send money flow, we don't pass in the iouReport, so based on this condition, it will not show the personal bank account.

What changes do you think we should make in order to solve the problem?

In the send money flow, we need to pass the iouType to SettlementButton and subsequently to AddPaymentMethodMenu. If the iouType is CONST.IOU.TYPE.SEND, we can allow the personal bank account to show.

We can add that condition to here, or can extract to a canUsePersonalBankAccount variable (similar pattern to the existing canUseBusinessBankAccount variable)

What alternative solutions did you explore? (Optional)

Pass a boolean, or a iouReport with only the type field, which can be used to indicate it's a send money request in AddPaymentMethodMenu.

@kevinksullivan

Hm, @kevinksullivan @joekaufmanexpensify can you guys chime in on this one?

My personal workspace currency is USD
I don't have a wallet enabled
I send money in USD
I tap Pay with Expensify on the confirmation screen
I see a debit card option?

Why aren't I prompted here to go through the flow and enable the wallet?

CC: @mountiny as well maybs from Bottom Up!

@dukenv0307

Bank account option will be present in Pay with Expensify menu

There should be no business bank account option when sending money 1:1, but there should be one for personal bank account

@dukenv0307 solution is right except we do not want the business bank account but personal one here, we only check for hte IOU report

App/src/components/AddPaymentMethodMenu.js

Lines 82 to 92 in a83a35d

    
           ...(ReportUtils.isIOUReport(iouReport) 
        
               ? [ 
        
                     { 
        
                         text: translate('common.personalBankAccount'), 
        
                         icon: Expensicons.Bank, 
        
                         onSelected: () => { 
        
                             onItemSelected(CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT); 
        
                         }, 
        
                     }, 
        
                 ] 
        
               : []),

but at this point there is no IOU report created yet so the option is not added

@dukenv0307

@dukenv0307 solution is right except we do not want the business bank account but personal one here, we only check for the IOU report

Thanks @mountiny for point out the right expectation here. Proposal updated to cover the case of personal bank account.

Reviewing label has been removed, please complete the "BugZero Checklist".

@aimane-chnaif

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Personal bank account option is not present in Pay with Expensify menu #32423

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@aimane-chnaif requires payment automatic offer (Reviewer)
@dukenv0307 requires payment automatic offer (Contributor)

@aimane-chnaif

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@aimane-chnaif

Hi @aimane-chnaif please complete the checklist above when you get a chance!

@trjExpensify

@trjExpensify, @mountiny, @aimane-chnaif, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

@trjExpensify

@trjExpensify, @mountiny, @aimane-chnaif, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?

@aimane-chnaif

@aimane-chnaif awaiting the checklist. What's your ETA on completing that, please?

The PR that introduced the bug has been identified. Link to the PR: Create v1 Collect workspace Bottom Up flow #30582
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30582/files#r1440329343
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

There's already regression test (caught by QA) so no need another one

@aimane-chnaif

Thanks! Confirming payments due are:

$500 to @aimane-chnaif for the C+ review
$500 to @dukenv0307 for the fix

Settled up!

Navigation Menu

Repository navigation

[HOLD for payment 2023-12-28] [$500] Send money - Bank account option is not present in Pay with Expensify menu #32228

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

24 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	...(ReportUtils.isIOUReport(iouReport)
	? [
	{
	text: translate('common.personalBankAccount'),
	icon: Expensicons.Bank,
	onSelected: () => {
	onItemSelected(CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT);
	},
	},
	]
	: []),

[HOLD for payment 2023-12-28] [$500] Send money - Bank account option is not present in Pay with Expensify menu #32228

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 29, 2023

melvin-bot commented on Nov 29, 2023

melvin-bot commented on Nov 29, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Nov 29, 2023

dukenv0307 commented on Nov 30, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

trjExpensify commented on Nov 30, 2023

mountiny commented on Nov 30, 2023

dukenv0307 commented on Dec 1, 2023

24 remaining items

melvin-bot commented on Dec 21, 2023

melvin-bot commented on Dec 21, 2023

melvin-bot commented on Dec 21, 2023

kevinksullivan commented on Dec 22, 2023

melvin-bot commented on Jan 1, 2024

melvin-bot commented on Jan 1, 2024

trjExpensify commented on Jan 3, 2024

aimane-chnaif commented on Jan 3, 2024

trjExpensify commented on Jan 3, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions