Repository navigation
[HOLD for payment 2023-12-12] Web/mweb - Account settings - Assigned cards in Wallet do not display card logos #32392
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.7-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
- Navigate to staging.new.expensify.com
- Log in with tester@applausecard.expensifail.com
- Tap on settings icon in LHN
- Select Wallet option
- Observe blank CC logos seen for assigned cards
Expected Result:
Assigned cards in Wallet should display relevant card logos
Actual Result:
Assigned cards in Wallet do not display card logos
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- Windows: Chrome
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6298050_1701471167451.Recording__2262.mp4
Activity
github-actions commentedon Dec 1, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 1, 2023
Triggered auto assignment to @NikkiWines (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.lanitochka17 commentedon Dec 1, 2023
Production:
NikkiWines commentedon Dec 1, 2023
I see the same issue on web on staging, so not specific to mWeb. Also don't see the issue on prod. Checking dev now
NikkiWines commentedon Dec 2, 2023
Same issue on dev. I think it's tied to #31776 and the changes made here
Checked out
b7f71ca(the commit before the merge commit (56a368b) for #31776) and confirmed the icon loaded. Then checked out56a368band confirmed I could reproduce the bug 🐛cc: @perunt @situchan @johnmlee101 @mountiny
NikkiWines commentedon Dec 2, 2023
Looks like a pretty beneficial PR overall so I'd like to err against reverting it. Let's see if we can't resolve the issue in isolation
NikkiWines commentedon Dec 2, 2023
Ah ok, looks like some of the
BANK_NAMESdefined here aren't quite right.Some of the old bank names from here were checked with
includesorstartsWithinstead of exact matches. As an example,expensifyin the PR linked should beexpensify card.I'll check and see what bank names we use on the backend and spin up a PR later today to update the names accordinglyWe have way too many options to match directly, so going to update this so we do a similar sort of matching that we did before
mountiny commentedon Dec 4, 2023
Thanks for handling it
[-]Web/mweb - Account settings - Assigned cards in Wallet do not display card logos[/-][+][HOLD for payment 2023-12-12] Web/mweb - Account settings - Assigned cards in Wallet do not display card logos[/+]melvin-bot commentedon Dec 5, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
situchan commentedon Dec 6, 2023
No payment is needed here. We can close this. Seems like being added to deploy checklist every time
NikkiWines commentedon Dec 6, 2023
Closing