Repository navigation
Design adjustments for the Hold/Next Steps/Scanning/Pending message #32434
Description
We'd like to make a few design adjustments to the Next Steps banner pattern we have. The adjustments should look like this:
- fixed badge width of 68px for better alignment on mobile
- use smaller font size (micro size at 11px) for the badge label
- use smaller font size (label size at 13px) for the next steps text
- use textSupporting color for the next steps text
- always put next step banner at the bottom of the header area, the primary button would go above this on mobile
cc @mountiny @JmillsExpensify @Expensify/design
Activity
melvin-bot commentedon Dec 4, 2023
Triggered auto assignment to @sophiepintoraetz (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.mountiny commentedon Dec 4, 2023
Asking in Slack which Callstack engineer can take this one
rezkiy37 commentedon Dec 4, 2023
Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.
mountiny commentedon Dec 4, 2023
Michael can start working on this on Wednesday
rezkiy37 commentedon Dec 4, 2023
Gonna to kick off on Wednesday.
rezkiy37 commentedon Dec 6, 2023
I've started working on the issue. Already have some drafts, will share soon.
rezkiy37 commentedon Dec 6, 2023
One thing that currently in the app there is only "Next Steps" message, so I am applying design adjustments for this.
13 remaining items
mountiny commentedon Dec 13, 2023
@jjcoffee to be paid $500
sophiepintoraetz commentedon Dec 20, 2023
Offer sent @jjcoffee
jjcoffee commentedon Dec 20, 2023
@sophiepintoraetz Thanks, offer accepted!
shawnborton commentedon Jan 4, 2024
Hi there, unfortunately this one wasn't quite implemented correctly. It looks like the line height used for the next steps text in production is too large. It should be 16px line height to match our mockups. @rezkiy37 can you please follow up with a fix?
Note the big gap between "Waiting" and "expenses" below?
cc @dannymcclain @dubielzyk-expensify for vizzy
[-][HOLD for payment 2023-12-20] Design adjustments for the Hold/Next Steps/Scanning/Pending message[/-][+]Design adjustments for the Hold/Next Steps/Scanning/Pending message[/+]mountiny commentedon Jan 4, 2024
Made this Quick PR #33957 if you want to check it out @shawnborton
rezkiy37 commentedon Jan 8, 2024
Hey, guys! I am back. @shawnborton do you still need any my help here?
shawnborton commentedon Jan 8, 2024
Ah, looks like Vit solved this one with a quick PR so I will close.