[HOLD for payment 2024-01-24] CRITICAL: [$750] Default new rooms to your primary workspace

@quinthar

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.7-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1701632317613889

Action Performed:

Click fab and select start chat

Expected Result:

workspace field should default to primary workspace

Actual Result:

workspace field is blank

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b604efe47660d3a4
Upwork Job ID: 1731962570569764864
Last Price Increase: 2024-01-08
Automatic offers:

alitoshmatov | Reviewer | 28003794
esh-g | Contributor | 28003795

@dylanexpensify

Triggered auto assignment to @dylanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When creating a Room, workspace should default to primary workspace

What is the root cause of that problem?

This is a feature request

We set a default value for policyID as null which makes the workspace field is blank

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 103 in 93121be

const [policyID, setPolicyID] = useState(null);

What changes do you think we should make in order to solve the problem?

We should create a useEffect to set the default value for policyID, we can set policy the first workspace in policies or the special workspace that we want to display by default

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

When creating a Room, workspace should default to primary workspace

What is the root cause of that problem?

Feature request. N/A

What changes do you think we should make in order to solve the problem?

We should do the following changes:

Make the workspace value picker a controlled input by adding the value={policyID} attribute to it here:

App/src/pages/workspace/WorkspaceNewRoomPage.js

Lines 272 to 277 in 6dbaa4a

    
           <ValuePicker 
        
               inputID="policyID" 
        
               label={translate('workspace.common.workspace')} 
        
               items={workspaceOptions} 
        
               onValueChange={setPolicyID} 
        
           />

Modify the ValuePicker to prevent a null value from causing an error here by using optional chaining(value?.length):

App/src/components/ValuePicker/index.js

Line 65 in 6dbaa4a

const descStyle = value.length === 0 ? StyleUtils.getFontSizeStyle(variables.fontSizeLabel) : null;
Add a useEffect to WorkspaceNewRoomPage to set the policyID to the first workspace:

useEffect(() => {
    setPolicyID(workspaceOptions[0].value);
}, [props.policies]);

What alternative solutions did you explore? (Optional)

Currently we don't have the activeWorkspace logic on newDot which is present on oldDot. In this issue, we are going to add a new Onyx key ACTIVE_WORKSPACE_ID which is exactly the use case for this.
After the implementation of the issue mentioned above, we can just access the ACTIVE_WORKSPACE_ID using the withOnyx HOC and initialise the state of the policyID to the passed prop.

Therefore, I think we can hold this issue until the ActiveWorkspace logic is implemented.

Job added to Upwork: https://www.upwork.com/jobs/~01b604efe47660d3a4

Yeah, I think no additional tests necessary for now

Reviewing label has been removed, please complete the "BugZero Checklist".

@alitoshmatov

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Default workspace rooms to active workspace #34160

If no regressions arise, payment will be issued on 2024-01-24. 🎊

For reference, here are some details about the assignees on this issue:

@alitoshmatov requires payment automatic offer (Reviewer)
@esh-g requires payment automatic offer (Contributor)

@alitoshmatov

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@alitoshmatov] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

coming up!

tomorrow!

Regression Test Proposal

Make sure you have a workspace
If you don't have a workspace create one and logout and login again
Click on FAB
Click on Start chat
Choose Room tab
Make sure you have a default workspace selected on workspace selection

Do we agree 👍 or 👎

@esh-g

Payment summary:

Contributor: @esh-g $750
Contributor+: @alitoshmatov $750

Please apply or request!

done

Navigation Menu

Repository navigation

[HOLD for payment 2024-01-24] CRITICAL: [$750] Default new rooms to your primary workspace #32435

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

97 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<ValuePicker
	inputID="policyID"
	label={translate('workspace.common.workspace')}
	items={workspaceOptions}
	onValueChange={setPolicyID}
	/>

[HOLD for payment 2024-01-24] CRITICAL: [$750] Default new rooms to your primary workspace #32435

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 4, 2023

dukenv0307 commented on Dec 4, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

esh-g commented on Dec 4, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Dec 5, 2023

97 remaining items

roryabraham commented on Jan 14, 2024

melvin-bot commented on Jan 17, 2024

melvin-bot commented on Jan 17, 2024

melvin-bot commented on Jan 17, 2024

dylanexpensify commented on Jan 17, 2024

dylanexpensify commented on Jan 23, 2024

alitoshmatov commented on Jan 24, 2024

dylanexpensify commented on Jan 29, 2024

dylanexpensify commented on Jan 29, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions