Repository navigation
[HOLD] TransitionEnd of react-navigation does not work properly on IOS #3283
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
This is a tracking issue and it is created so that we can revert to original transitionEnd event on IOS as well when this is fixed at Library level react-navigation.
Related PR: #2956
Expected Result:
transitionEnd should fire consistently for screens on IOS as well.
Actual Result:
For stack router, transitionEnd does not fire regularly on navigation screens on IOS devices. This seems to be an issue with underlying react-native-screens. This event is necessary to delay the main logic until the animation is finished to run the animation at > 50FPS.
Action Performed:
- Subscribe to
transitionEndevent on the search page as follows:
navigation.addListener('transitionEnd', callback);
- Every time, when we go to searchPage, this should fire.
Workaround:
Yes, Due to the reason that react-navigation register Interactions, we can utilize InteractionManager and it is fully supported on Native devices.
Platform:
Where is this issue occurring?
Web
iOS ✅
Android
Desktop App
Mobile Web
Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Activity
MelvinBot commentedon Jun 2, 2021
Triggered auto assignment to @MitchExpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.[-][Hold][Tracking issue] TransitionEnd of react-navigation does not work properly on IOS[/-][+][HOLD] TransitionEnd of react-navigation does not work properly on IOS[/+]marcaaron commentedon Jun 7, 2021
This is not really actionable yet so I'm un-assigning @MitchExpensify and we can wait until there is movement at the library level...
@parasharrajat can you please include details about what library we are expecting will be updated?
MelvinBot commentedon Nov 29, 2021
@parasharrajat, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.