Skip to content

[HOLD for payment 2024-03-05] [Contributor] Add Visit Expensify Classic Button to NewDot #32875

Closed

Description

@danielrvidal

Part of #wave9-collect-signups project

Main issue: Originated from this internal issue: https://github.com/Expensify/Expensify/issues/344901
Doc section: no design doc - this was pre-designed already.
Project: #wave9-collect-signups

Feature Description

Problem: As we start migrating users from OldDot to NewDot and point new signUps to NewDot, some users will require OldDot functionality to complete tasks, add secondary logins, use functionality not available on NewDot, access old expense/reports, and so on. If a user currently is in NewDot, the most straightforward way to access OldDot is to open a new tab and type in expensify.com to get to OldDot, which causes confusion. If they have the tryNewDot redirect, typing in expensify.com would not work and you’d have to send them a specific link or instructions how to do so.

Solution: Add a button in NewDot to allow user to easily navigate to OldDot.

  • Note: some users have the tryNewDot NVP applied to their accounts which means if they type in www.expensify.com, they are redirected to OldDot. This will not remove the NVP but will allow the user to be taken to the inbox.

Where will we add the button?
You’d find the button by going to Avatar > Settings. Then above Sign Out we’ll add the button Go to Expensify Classic (Image in thread of where it will go). Mock up here:

image

What will the button do?

  • Web (desktop/mobile) - opens up a new tab for https://www.expensify.com/inbox
  • NewDot App - leaves the app and opens up a new tab for https://www.expensify.com/inbox in your default browser
  • [HOLD] HybridApp - stays in HybridApp and goes to settings in OldDot. The hybrid app is not ready yet so we do not need to account for this use case yet, but just accounting that it will be here later.

I think this should have everything you need to complete this. Please feel free to ask me any questions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0183075eef93ad0483
  • Upwork Job ID: 1734346213197549568
  • Last Price Increase: 2023-12-11
Issue OwnerCurrent Issue Owner: @kadiealexander

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    NewFeatureSomething to build that is a new item.
    on Dec 11, 2023
  2. melvin-bot commented on Dec 11, 2023

    @melvin-bot
  3. melvin-bot commented on Dec 11, 2023

    @melvin-bot
  4. melvin-bot commented on Dec 11, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

  5. neonbhai commented on Dec 11, 2023

    @neonbhai
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Add Visit Expensify Classic Button to NewDot

    What is the root cause of that problem?

    New Feature

    What changes do you think we should make in order to solve the problem?

    We will be adding another menuItem here, before Sign Out button.

    {
    translationKey: 'initialSettingsPage.signOut',
    icon: Expensicons.Exit,
    action: () => {
    signOut(false);
    },
    },

    {
        translationKey: 'initialSettingsPage.goToExpensifyClassic',
        icon: Expensicons.Expensify,
        iconRight: Expensicons.NewWindow,
        action: () => {    
            Linking.openURL(CONST.OLDDOT_URL);
        },
    },

    And add this CONST variable:

    OLDDOT_URL: 'https://www.expensify.com/'
  6. AndrewGable commented on Dec 12, 2023

    @AndrewGable
    Contributor

    @neonbhai - This issue is labeled internal, which means it's not currently open to proposals. We will let you know if this changes in the future. Thanks!

  7. neonbhai commented on Dec 12, 2023

    @neonbhai
    Contributor

    @AndrewGable ah right. Thanks!

  8. barttom commented on Dec 12, 2023

    @barttom
    Contributor

    Hey, I'm Bartek from Callstack - expert contributor group - I would like to work on this issue

  9. barttom commented on Dec 12, 2023

    @barttom
    Contributor

    I haven't found a needed icon for this item, so I've converted https://github.com/Expensify/App/blob/main/assets/images/expensify-logo-round-transparent.png as best as I could 🙈
    If exists that icon in SVG format or if You have it prepared please let me know

  10. 68 remaining items

  11. changed the title [-][HOLD for payment 2024-01-24] [Contributor] Add Visit Expensify Classic Button to NewDot[/-] [+][HOLD for regression fix] [Contributor] Add Visit Expensify Classic Button to NewDot[/+] on Feb 7, 2024
  12. kadiealexander commented on Feb 7, 2024

    @kadiealexander
    Contributor

    Not overdue, please switch back to daily when the regression fix is deployed.

  13. changed the title [-][HOLD for regression fix] [Contributor] Add Visit Expensify Classic Button to NewDot[/-] [+][HOLD for payment 2024-03-07] [Contributor] Add Visit Expensify Classic Button to NewDot[/+] on Feb 29, 2024
  14. kadiealexander commented on Feb 29, 2024

    @kadiealexander
    Contributor

    Not overdue, regression was merged 2 days ago.

  15. changed the title [-][HOLD for payment 2024-03-07] [Contributor] Add Visit Expensify Classic Button to NewDot[/-] [+][HOLD for payment 2024-03-05] [Contributor] Add Visit Expensify Classic Button to NewDot[/+] on Feb 29, 2024
  16. melvin-bot commented on Mar 5, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @barttom is from an agency-contributor and not due payment
    • Reviewer: @thesahindia owed $250 via NewDot

    BugZero Checklist (@kadiealexander)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1734346213197549568/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. melvin-bot commented on Mar 5, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @barttom is from an agency-contributor and not due payment
    • Reviewer: @thesahindia owed $500 via NewDot

    BugZero Checklist (@kadiealexander)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1734346213197549568/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  18. kadiealexander commented on Mar 6, 2024

    @kadiealexander
    Contributor

    I have updated the payment amount to reflect the regression. @thesahindia please request payment via NewDot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDesignInternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions