[$500] Codeblocks does not wrap

@quinthar

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.13-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1702572793589809

Action Performed:

Open any chat
Send a lengthy codeblock message

Expected Result:

Should wrap themessage

Actual Result:

Message does not wrap

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0128f71c5292f13b05
Upwork Job ID: 1735401155881005056
Last Price Increase: 2023-12-14
Automatic offers:

cubuspl42 | Reviewer | 28067470
Krishna2323 | Contributor | 28067471

@sakluger

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~0128f71c5292f13b05

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

@quinthar

What do you mean by wrap the message? the attached example's message is already in a code block @quinthar

Proposal

Please re-state the problem that we are trying to solve in this issue.

Codeblocks does not wrap.

What is the root cause of that problem?

We wrap the code block text with ScrollView with horizontal prop passed to it, that makes it scrollable horizontally and does not wrap the text.

App/src/components/HTMLEngineProvider/HTMLRenderers/PreRenderer/BasePreRenderer.js

Lines 41 to 43 in 648c000

    
           <ScrollView 
        
               ref={ref} 
        
               horizontal

What changes do you think we should make in order to solve the problem?

By removing the horizontal prop this issue can be solved, we would also need to cleanup some code related to scrolling if we decide to remove the horizontal prop. IMO we should remove it just to be consistent with the inline code block view.

We can also add maxHeight to the code block if we want to make the code block scrollable after reaching maxHeight.

Result

pre_styling_issue.mp4

What alternative solutions did you explore? (Optional)

We can remove the ScrollView element if needed.

@abzokhattab

@abzokhattab In the example provided, you can see that when the user enters a long text string in code blocks, they must scroll right and left to see the full message. In the screenshot from Slack, the text in the code block wraps and the user doesn't need to scroll right and left.

For future reference, this seems unrelated to #27913

@sakluger

@cubuspl42 @sakluger @jasperhuangg @Krishna2323 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@cubuspl42, PR ready for review.

PR is 🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.22-6 🚀

@sakluger

@sakluger, I think this is ready for payments.

@sakluger

@sakluger, bump for payments.

@sakluger

@sakluger melv failed here😭, can you pls process the payments🙃

Asked on Slack

Thanks for the bump, all paid out!

Navigation Menu

Repository navigation

[$500] Codeblocks does not wrap #33115

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What alternative solutions did you explore? (Optional)

31 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$500] Codeblocks does not wrap #33115

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 14, 2023

melvin-bot commented on Dec 14, 2023

melvin-bot commented on Dec 14, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Dec 14, 2023

abzokhattab commented on Dec 14, 2023

Krishna2323 commented on Dec 14, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What alternative solutions did you explore? (Optional)

sakluger commented on Dec 14, 2023

jakub-trzebiatowski commented on Dec 15, 2023

31 remaining items

melvin-bot commented on Dec 28, 2023

Krishna2323 commented on Dec 30, 2023

Krishna2323 commented on Jan 9, 2024

Krishna2323 commented on Jan 15, 2024

Krishna2323 commented on Jan 19, 2024

Krishna2323 commented on Jan 24, 2024

jakub-trzebiatowski commented on Jan 24, 2024

sakluger commented on Jan 24, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions