You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-11] [$500] Status - Highlighting minutes and pressing Back key does not reset it to 00 #33143
Version Number: v1.4.13-2 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @
Action Performed:
Go to staging.new.expensify.com.
Go to Settings > Profile > Status.
Click Clear after.
Click Custom > Time.
Highlight the minutes.
Press Back key on keyboard.
Expected Result:
The minutes will be reset to 00.
Actual Result:
Nothing happens to the minutes and the cursor moves to the beginning of hours.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Status - Highlighting minutes and pressing Back key does not reset it to 00[/-][+][$500] Status - Highlighting minutes and pressing Back key does not reset it to 00[/+]on Dec 15, 2023
changed the title [-][$500] Status - Highlighting minutes and pressing Back key does not reset it to 00[/-][+][HOLD for payment 2024-01-11] [$500] Status - Highlighting minutes and pressing Back key does not reset it to 00[/+]on Jan 4, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.21-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-11. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
A discussion in #expensify-bugs has been started: I don't think this is needed
Determine if we should create a regression test for this bug: The work done here is mostly adding missing features and fixing bugs for a component that is newly written. I don't think we require a regression test in this case
Issue is ready for payment but no BZ is assigned. @lschurr you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Activity
[-]Status - Highlighting minutes and pressing Back key does not reset it to 00[/-][+][$500] Status - Highlighting minutes and pressing Back key does not reset it to 00[/+]melvin-bot commentedon Dec 15, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01a5a5a8e401086431
melvin-bot commentedon Dec 15, 2023
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 15, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Dec 15, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)42 remaining items
[-][$500] Status - Highlighting minutes and pressing Back key does not reset it to 00[/-][+][HOLD for payment 2024-01-11] [$500] Status - Highlighting minutes and pressing Back key does not reset it to 00[/+]melvin-bot commentedon Jan 4, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 4, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.21-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-11. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 4, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
s77rt commentedon Jan 7, 2024
melvin-bot commentedon Jan 11, 2024
Issue is ready for payment but no BZ is assigned. @lschurr you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
lschurr commentedon Jan 11, 2024
Hmm @bfitzexpensify is already on this one. Are you able to handle, Benny? Un-assigning myself :)
bfitzexpensify commentedon Jan 11, 2024
Payments complete, agreed we don't need a regression test here. Closing this one out.