[$125] Room-In offline, notify settings displays daily but in online changed to immediately

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Precondition : Toggle on forced offline

Launch app
Tap fab
Tap start chat
Tap room
Create a room
Tap on room header--- settings
Note, notify me daily options displayed
Toggle off forced offline
Tap on room chat
Tap on room header--- Settings

Expected Result:

While creating room in offline, the notify me settings displays daily so after changing to online the settings must remain same daily and must not show immediately.

Actual Result:

In offline, create room and note "notify me settings displays daily" and change to online and check "notify me settings displays immediately".

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6314274_1702633245585.dailt.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e0d9c2705dbcfd9a
Upwork Job ID: 1735617681553616896
Last Price Increase: 2024-01-03
Automatic offers:

situchan | Reviewer | 28079652
paultsimura | Contributor | 28079653

Job added to Upwork: https://www.upwork.com/jobs/~01e0d9c2705dbcfd9a

@isabelastisser

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@situchan

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room-In offline, notify settings displays daily but in online changed to immediately

What is the root cause of that problem?

By default, in a new room, the notification preference is daily.

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 137 in 31f79a6

CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY,

.

When we go online, it changes to immediately.

What changes do you think we should make in order to solve the problem?

Change to it Immediately.

What alternative solutions did you explore? (Optional)

On the backend, change the policy to use Daily instead.

Proposal

Please pay attention to the edit history of the proposal above – it was posted empty.

Please re-state the problem that we are trying to solve in this issue.

The notification preference of a room changes from daily to always when coming back online.

What is the root cause of that problem?

When creating a room, there is a discrepancy in the optimistic value of notificationPreference: "daily" and the response from the BE: notificationPreference: "always".

App/src/libs/actions/Report.ts

Line 1641 in ac358ef

    
           API.write('AddWorkspaceRoom', parameters, {optimisticData, successData, failureData});

What changes do you think we should make in order to solve the problem?

If we take the BE as the source of truth, we should set the optimistic value to "always" as well, so it will be consistent.
If we want the daily to be the default preference, we should modify the data BE sends in response to AddWorkspaceRoom API call.

What alternative solutions did you explore? (Optional)

@isabelastisser

@isabelastisser, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@situchan

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@paultsimura

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

Thanks. The PR is ready for review: #33924

The PR was deployed to prod, automation here didn't work: #33924 (comment)

@situchan

@situchan, what's next here? Are we waiting for regressions before we can process the payment?

@situchan

@situchan, what's next here? Are we waiting for regressions before we can process the payment?

yes

Thanks!

@isabelastisser

@isabelastisser this is due payment today.
The automation didn't work on deployment: #33924 (comment)

@paultsimura

Payments were made in Upwork.

@paultsimura Contributor $125
@situchan Contributor+ $125

Navigation Menu

Repository navigation

[$125] Room-In offline, notify settings displays daily but in online changed to immediately #33150

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

27 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$125] Room-In offline, notify settings displays daily but in online changed to immediately #33150

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 15, 2023

melvin-bot commented on Dec 15, 2023

melvin-bot commented on Dec 15, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Dec 15, 2023

GItGudRatio commented on Dec 15, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

paultsimura commented on Dec 15, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Dec 18, 2023

27 remaining items

melvin-bot commented on Jan 3, 2024

melvin-bot commented on Jan 3, 2024

paultsimura commented on Jan 4, 2024

paultsimura commented on Jan 9, 2024

isabelastisser commented on Jan 9, 2024

situchan commented on Jan 9, 2024

isabelastisser commented on Jan 9, 2024

paultsimura commented on Jan 16, 2024

isabelastisser commented on Jan 16, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions