You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-25] [$500] Deleted IOU offline disappears after going online if it has already been paid for by another user. #33158
Version Number: 1.4.13-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
changed the title [-]Deleted IOU offline disappears after going online if it has already been paid for by another user.[/-][+][$500] Deleted IOU offline disappears after going online if it has already been paid for by another user.[/+]on Dec 15, 2023
This will show the strikethrough text while offline. If we pay the request from the requested user, the delete action will fail when we come back online. If fails, the error message will show with a close button, but the DELETE pendingAction still exists.
If the pendingAction is DELETE while online, the view should be hidden, but because we have an error message, the view is displayed.
changed the title [-][$500] Deleted IOU offline disappears after going online if it has already been paid for by another user.[/-][+][HOLD for payment 2024-01-25] [$500] Deleted IOU offline disappears after going online if it has already been paid for by another user.[/+]on Jan 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
[@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hoangzinh] Determine if we should create a regression test for this bug.
[@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. ✅ YES
Activity
[-]Deleted IOU offline disappears after going online if it has already been paid for by another user.[/-][+][$500] Deleted IOU offline disappears after going online if it has already been paid for by another user.[/+]melvin-bot commentedon Dec 15, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01fed1ad1953a51e12
melvin-bot commentedon Dec 15, 2023
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 15, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Dec 15, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (
External)namhihi237 commentedon Dec 15, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Deleted IOU offline disappears after going online if it has already been paid for by another user
What is the root cause of that problem?
In here we only clear errors in the reportAction the pendingAction still delete
So the IOU will hide because this condition
App/src/components/OfflineWithFeedback.tsx
Line 92 in e23eebe
What changes do you think we should make in order to solve the problem?
We should remove the pendingAction when clear the error message too.
What alternative solutions did you explore? (Optional)
bernhardoj commentedon Dec 15, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
If we close the request/transaction delete error message, the report action also disappears, but it should stay visible.
What is the root cause of that problem?
When we delete the request, we optimistically set the
pendingActionto DELETE.App/src/libs/actions/IOU.js
Lines 2274 to 2276 in 275bd03
This will show the strikethrough text while offline. If we pay the request from the requested user, the delete action will fail when we come back online. If fails, the error message will show with a close button, but the DELETE
pendingActionstill exists.If the
pendingActionis DELETE while online, the view should be hidden, but because we have an error message, the view is displayed.App/src/components/OfflineWithFeedback.tsx
Line 83 in 275bd03
App/src/components/OfflineWithFeedback.tsx
Line 92 in 275bd03
So, once we press the close error message, the request view is hidden.
What changes do you think we should make in order to solve the problem?
We should clear the
pendingActionwhen the delete fails.App/src/libs/actions/IOU.js
Lines 2443 to 2450 in 275bd03
abekkala commentedon Dec 15, 2023
Dupe of 26511
Closing
36 remaining items
[-][$500] Deleted IOU offline disappears after going online if it has already been paid for by another user.[/-][+][HOLD for payment 2024-01-25] [$500] Deleted IOU offline disappears after going online if it has already been paid for by another user.[/+]melvin-bot commentedon Jan 18, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-25. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 18, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
abekkala commentedon Jan 24, 2024
PAYMENTS FOR JAN 25
hoangzinh commentedon Jan 24, 2024
Regression Test Proposal
I would like to borrow the Test steps of @bernhardoj in his PR here #34469
Do we agree 👍 or 👎
hoangzinh commentedon Jan 24, 2024
BugZero Checklist:
abekkala commentedon Jan 25, 2024
@bernhardoj @hoangzinh payments sent and contracts ended - thank you! 🎉