Slightly scrolling up in compose box will dismiss the keyboard

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Expected Result:

Scrolling up in a long message should not dismiss the keyboard.

Actual Result:

Slightly scrolling up the message in compose box will dismiss the keyboard.

Action Performed:

Log in on mobile app
Navigate to a conversation
Tap on compose box and write a long message (long enough to enable scrolling)
Scroll the message to the top.

Workaround:

User has to recall the keyboard everytime after scrolling up.

Platform:

Where is this issue occurring?

Web
iOS ✔️
Android ✔️
Desktop App
Mobile Web

Version Number: 1.0.61-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

nosound.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@bondydaa

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

tossing to the pool

Issue reproducible today during KI retests

@kevinksullivan

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Issue reproducible today during KI retests

Sorry for the delay on this one. Posted to upwork!

https://www.upwork.com/jobs/~01b905fa59a688b29f

@puneetlath

Triggered auto assignment to @puneetlath (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Proposal

We are using PanRasponder over the Composer to close it but it lacks two basic checks.
First we should only close the keyboard when the user is swiping down.
Second, We need to increase the swipe distance, as optional we can also check for the velocity of the swipe so that if a user is swiping fast , only then close it. (Let me know about this optional part).
To fix the above problem at base we need to do the following update to code here https://github.com/Expensify/Expensify.cash/blob/408b7e00cf33c16600af0b67b819c764fcb5388a/src/components/SwipeableView/index.native.js#L16

// We increase the distance, we need to carefully adjust this value but I suggest it should be equal to the max height of composer
        const minimumPixelDistance = 116;
        this.oldY = 0;
        this.panResponder = PanResponder.create({

            // The PanResponder gets focus only when the y-axis movement is over minimumPixelDistance
            onMoveShouldSetPanResponderCapture:
            (_event, gestureState) => {
                // we only close it when direction is bottom and minimumdistance is covered.
                if ((gestureState.dy - this.oldY) > 0 && gestureState.dy > minimumPixelDistance) { return true; }
                this.oldY = gestureState.dy;
            },

            // Calls the callback when the swipe down is released; after the completion of the gesture
            onPanResponderRelease: this.props.onSwipeDown,
        });
    }
    ```

Issue reproducible today during KI retests.

I say we just try 2 first and see how that feels. Then we can add 3 in a follow up issue if we think it's also necessary.

@parasharrajat

Hired @parasharrajat !

Paid in upwork

Navigation Menu

Repository navigation

Slightly scrolling up in compose box will dismiss the keyboard #3323

Expected Result:

Actual Result:

Action Performed:

Workaround:

Platform:

Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Slightly scrolling up in compose box will dismiss the keyboard #3323

Description

Expected Result:

Actual Result:

Action Performed:

Workaround:

Platform:

Activity

MelvinBot commented on Jun 2, 2021

bondydaa commented on Jun 2, 2021

isagoico commented on Jun 7, 2021

MelvinBot commented on Jun 7, 2021

isagoico commented on Jun 13, 2021

kevinksullivan commented on Jun 19, 2021

MelvinBot commented on Jun 19, 2021

parasharrajat commented on Jun 19, 2021

Proposal

isagoico commented on Jun 21, 2021

puneetlath commented on Jun 22, 2021

kevinksullivan commented on Jun 22, 2021

kevinksullivan commented on Jul 1, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions