[HOLD for payment 2024-02-19] [$500] Distance - Receipt shows original amount and distance instead of TBD when editing distance offline

@kevinksullivan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.14-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: There is a distance expense request in the workspace chat.

Navigate to the workspace chat from the precondition.
Open the distance request details page.
Click on the receipt.
Close the receipt.
Go offline.
Click Distance.
Add a stop and save it.
Click on the receipt.

Expected Result:

The amount and distance will show TBD.

Actual Result:

The amount and distance are not showing TBD. The values are still showing the original value before edit.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6321335_1703081373259.bandicam_2023-12-15_03-44-39-835.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d635e8deae97ab55
Upwork Job ID: 1737476292940328960
Last Price Increase: 2024-01-03
Automatic offers:

paultsimura | Contributor | 28089473

Issue Owner

Current Issue Owner: @kevinksullivan

Job added to Upwork: https://www.upwork.com/jobs/~01d635e8deae97ab55

@kevinksullivan

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@parasharrajat

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

The amount and distance are not showing TBD. The values are still showing the original value before edit.

What is the root cause of that problem?

We don't use the same condition to show TDB as we do in MoneyRequestView. The same for merchant

App/src/components/DistanceEReceipt.js

Line 38 in 249096e

    
           const formattedTransactionAmount = transactionAmount ? CurrencyUtils.convertToDisplayString(transactionAmount, transactionCurrency) : translate('common.tbd');

App/src/components/ReportActionItem/MoneyRequestView.js

Lines 108 to 110 in 249096e

    
           if (isDistanceRequest && (!formattedTransactionAmount || hasPendingWaypoints)) { 
        
               formattedTransactionAmount = translate('common.tbd'); 
        
           }

What changes do you think we should make in order to solve the problem?

We should use the same condition to show the amount and merchant as we do in MoneyRequestView here

App/src/components/DistanceEReceipt.js

Line 38 in 249096e

    
           const formattedTransactionAmount = transactionAmount ? CurrencyUtils.convertToDisplayString(transactionAmount, transactionCurrency) : translate('common.tbd');

App/src/components/ReportActionItem/MoneyRequestView.js

Lines 108 to 110 in 249096e

    
           if (isDistanceRequest && (!formattedTransactionAmount || hasPendingWaypoints)) { 
        
               formattedTransactionAmount = translate('common.tbd'); 
        
           }

What alternative solutions did you explore? (Optional)

NA

Proposal

Please re-state the problem that we are trying to solve in this issue.

Amount and Distance are not replaced with TBD in the eReceipt.

What is the root cause of that problem?

We currently show TBD only if the request has no initial amount:

App/src/components/DistanceEReceipt.js

Line 38 in fa87f8b

    
           const formattedTransactionAmount = transactionAmount ? CurrencyUtils.convertToDisplayString(transactionAmount, transactionCurrency) : translate('common.tbd');

What changes do you think we should make in order to solve the problem?

We should add a check for transaction.isLoading, and show TBD in this case as well:

const formattedTransactionAmount = !transaction.isLoading && transactionAmount ? CurrencyUtils.convertToDisplayString(transactionAmount, transactionCurrency) : translate('common.tbd');
const formattedMerchant = transaction.isLoading ? transactionMerchant.replace(CONST.REGEX.FIRST_SPACE, translate('common.tbd')) : transactionMerchant;

And use this formattedMerchant instead of transactionMerchant here:

App/src/components/DistanceEReceipt.js

Line 77 in fa87f8b

<Text style={styles.eReceiptMerchant}>{transactionMerchant}</Text>

What alternative solutions did you explore? (Optional)

Instead of using transaction.isLoading, we can use the hasPendingWaypoints approach, but it was already discussed in a couple of places that we should move towards using transaction.isLoading instead of checking for pending waypoints, as it can be more dynamically controlled in one single place instead of later modifying the hasPendingWaypoints check in every single place where we use the TBD.

This transaction.isLoading is being set in one single place when modifying the transaction, so it should be relied on as the source of truth for the distance transaction being in pending status:

App/src/libs/actions/IOU.js

Lines 936 to 946 in 249096e

    
           // Optimistically modify the transaction 
        
           optimisticData.push({ 
        
               onyxMethod: Onyx.METHOD.MERGE, 
        
               key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, 
        
               value: { 
        
                   ...updatedTransaction, 
        
                   pendingFields, 
        
                   isLoading: _.has(transactionChanges, 'waypoints'), 
        
                   errorFields: null, 
        
               }, 
        
           });

@parasharrajat

Hi @parasharrajat please review the proposal!

Checking this in 2 hours.

Reviewing label has been removed, please complete the "BugZero Checklist".

@paultsimura

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: unify TBD-related logic for Distance requests #34135

If no regressions arise, payment will be issued on 2024-02-19. 🎊

For reference, here are some details about the assignees on this issue:

@paultsimura requires payment automatic offer (Contributor)
@parasharrajat requires payment through NewDot Manual Requests

@parasharrajat

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

False alert – I used this issue as a reference.

@paultsimura

I think the issue is eligible for a bonus due to the scope change on the PR. @paultsimura did great job in handling and managing the discussion till the end.

@amyevans

@amyevans, @paultsimura, @kevinksullivan, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@parasharrajat

Payment summary:

C+ @parasharrajat $500
Contributor @paultsimura $500

Payment requested as per #33362 (comment)

@parasharrajat

$500 approved for @parasharrajat

Navigation Menu

Repository navigation

[HOLD for payment 2024-02-19] [$500] Distance - Receipt shows original amount and distance instead of TBD when editing distance offline #33362

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

46 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (isDistanceRequest && (!formattedTransactionAmount \|\| hasPendingWaypoints)) {
	formattedTransactionAmount = translate('common.tbd');
	}

	// Optimistically modify the transaction
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`,
	value: {
	...updatedTransaction,
	pendingFields,
	isLoading: _.has(transactionChanges, 'waypoints'),
	errorFields: null,
	},
	});

[HOLD for payment 2024-02-19] [$500] Distance - Receipt shows original amount and distance instead of TBD when editing distance offline #33362

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 20, 2023

melvin-bot commented on Dec 20, 2023

melvin-bot commented on Dec 20, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Dec 20, 2023

dukenv0307 commented on Dec 20, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

paultsimura commented on Dec 20, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

kevinksullivan commented on Dec 22, 2023

parasharrajat commented on Dec 22, 2023

46 remaining items

melvin-bot commented on Feb 12, 2024

melvin-bot commented on Feb 12, 2024

melvin-bot commented on Feb 12, 2024

melvin-bot commented on Feb 20, 2024

paultsimura commented on Feb 20, 2024

parasharrajat commented on Feb 20, 2024

melvin-bot commented on Feb 21, 2024

kevinksullivan commented on Feb 22, 2024

parasharrajat commented on May 13, 2024

JmillsExpensify commented on May 19, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions