[HOLD for payment 2024-01-11] [$500] Status - Unable to set custom time after selecting the duration

@tylerkaraszewski

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.15-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Go to Settings > Profile > Status.
Click Clear after.
Select 30 minutes.
Click Clear after.
Click Date under Custom.
Select a different date.

Expected Result:

The selected date is saved.

Actual Result:

The selected date is not saved.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6322802_1703170066823.bandicam_2023-12-21_21-40-14-801.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f4c9ce5463b9747c
Upwork Job ID: 1737863065032630272
Last Price Increase: 2023-12-21
Automatic offers:

paultsimura | Contributor | 28067990

Issue Owner

Current Issue Owner: @tylerkaraszewski

Job added to Upwork: https://www.upwork.com/jobs/~01f4c9ce5463b9747c

@adelekennedy

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@parasharrajat

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Changing date in Status' DatePicker does nothing.

What is the root cause of that problem?

When selecting the date value, the actual form's value of the wrapping <FormProvider> is not updated because the DatePicker is not properly wrapped in the <InputWrapper>

What changes do you think we should make in order to solve the problem?

We should use <InputWrapper> here:

                <InputWrapper
                    InputComponent={DatePicker}
                    inputID="dateTime"
                    label={translate('statusPage.date')}
                    defaultValue={DateUtils.extractDate(customClearAfter)}
                    minDate={new Date()}
                />

App/src/pages/settings/Profile/CustomStatus/SetDatePage.js

Lines 61 to 66 in fd71747

    
           <DatePicker 
        
               inputID="dateTime" 
        
               label={translate('statusPage.date')} 
        
               defaultValue={DateUtils.extractDate(customClearAfter)} 
        
               minDate={new Date()} 
        
           />

What alternative solutions did you explore? (Optional)

@paultsimura

@paultsimura's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

@tylerkaraszewski

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@michaelhaxhiu

Issue is ready for payment but no BZ is assigned. @michaelhaxhiu you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@parasharrajat

@parasharrajat bump on the checklist

@paultsimura

Payouts due:

Contributor: $500 @paultsimura (Upwork)
Contributor+: $500 @parasharrajat (NewDot)

@parasharrajat

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Status clear after #24620
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/24620/files#r1452906767
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed. We should written guidelines.
[@parasharrajat] Determine if we should create a regression test for this bug. Not needed
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Go to Settings > Profile > Status
Click "Clear after"
Click Custom > Date
Select a date in the future
Click "Save"

Do you agree 👍 or 👎 ?

@tylerkaraszewski

I'll kick it to @tylerkaraszewski for any changes/other thoughts on the regression test but that makes sense to me

I think that's fine.

Payment requested as per #33423 (comment)

@parasharrajat

$500 approved for @parasharrajat

Navigation Menu

Repository navigation

[HOLD for payment 2024-01-11] [$500] Status - Unable to set custom time after selecting the duration #33423

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

25 remaining items

Payouts due:

Regression Test Steps

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<DatePicker
	inputID="dateTime"
	label={translate('statusPage.date')}
	defaultValue={DateUtils.extractDate(customClearAfter)}
	minDate={new Date()}
	/>

[HOLD for payment 2024-01-11] [$500] Status - Unable to set custom time after selecting the duration #33423

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 21, 2023

melvin-bot commented on Dec 21, 2023

melvin-bot commented on Dec 21, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Dec 21, 2023

paultsimura commented on Dec 21, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

parasharrajat commented on Dec 22, 2023

melvin-bot commented on Dec 22, 2023

25 remaining items

melvin-bot commented on Jan 11, 2024

adelekennedy commented on Jan 15, 2024

adelekennedy commented on Jan 15, 2024

Payouts due:

parasharrajat commented on Jan 16, 2024

Regression Test Steps

adelekennedy commented on Jan 17, 2024

tylerkaraszewski commented on Jan 22, 2024

parasharrajat commented on May 13, 2024

JmillsExpensify commented on May 19, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions