Skip to content

[HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - Message for cancelation is not copied and "owes" message is copied as "paid" #33507

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.16-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32674

Action Performed:

  1. Go to workspace chat
  2. Create a manual request
  3. Open expense report
  4. Click Pay elsewhere
  5. Click 3-dot menu > Cancel payment
  6. Right click on the system message > Copy to clipboard
  7. Paste it on the composer
  8. Right click on the 'owes' message > Copy to clipboard
  9. Paste it on the composer

Expected Result:

In Step 7, the system message for payment cancelation is copied
In Step 9, the exact "owes" message is copied

Actual Result:

In Step 7, the system message for payment cancelation is not copied.
In Step 9, the "paid" message is copied instead of "owes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6324139_1703263478535.bandicam_2023-12-22_17-21-56-862__1_.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 22, 2023
  2. melvin-bot commented on Dec 22, 2023

    @melvin-bot

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Dec 22, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. github-actions commented on Dec 22, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Dec 22, 2023

    @melvin-bot

    Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

  6. Tony-MK commented on Dec 22, 2023

    @Tony-MK
  7. 24 remaining items

  8. changed the title [-][HOLD for payment 2024-01-25] Cancel payment - Message for cancelation is not copied and "owes" message is copied as "paid"[/-] [+][HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - Message for cancelation is not copied and "owes" message is copied as "paid"[/+] on Jan 19, 2024
  9. melvin-bot commented on Jan 19, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-01-26. 🎊

  10. melvin-bot commented on Jan 19, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Gonals] The PR that introduced the bug has been identified. Link to the PR:
    • [@Gonals] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Gonals] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Gonals] Determine if we should create a regression test for this bug.
    • [@Gonals] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. melvin-bot commented on Feb 12, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @Gonals eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  12. melvin-bot commented on Apr 25, 2024

    @melvin-bot

    @Gonals, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringMonthlyKSv2Not a priority

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions