You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment-Add receipt and Delete request options are present after canceling Send money payment #33517
Version Number: 1.4.16-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Go to 1:1 DM > + > Send money
Send the money
Click on the IOU preview in the main chat
Click 3-dot menu > Cancel payment > Cancel payment
Click on the IOU preview to open IOU details page
Click 3-dot menu
Click Add receipt
Click Delete request
Expected Result:
"Add receipt" and "Delete request" options should not be present for Send money request
Actual Result:
"Add receipt" and "Delete request" options are present for Send money request
"Add receipt" button does nothing
"Delete request" results in the IOU preview to become skeleton placeholder in IOU report and TBD in the main chat
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
After canceling the "Send Money" request, it starts to behave as a regular Manual request.
What is the root cause of that problem?
This is because we do not differentiate between a Manual and "Send" requests. We've always been checking for the request to be settled, like for the header here – we show the "editing" items in the 3-dots menu based on this condition:
And after canceling, the "Send" request becomes unsettled.
What changes do you think we should make in order to solve the problem?
I think it's important to differentiate all the IOU requests by populating their transaction or the Money Request Report with an iouType (and maybe the requestType) when placing the request:
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-][HOLD for payment 2024-01-25] Cancel payment-Add receipt and Delete request options are present after canceling Send money payment[/-][+][HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment-Add receipt and Delete request options are present after canceling Send money payment[/+]on Jan 19, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
This issue has not been updated in over 15 days. @Gonals eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
github-actions commentedon Dec 22, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 22, 2023
Triggered auto assignment to @srikarparsi (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.paultsimura commentedon Dec 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
After canceling the "Send Money" request, it starts to behave as a regular Manual request.
What is the root cause of that problem?
This is because we do not differentiate between a Manual and "Send" requests. We've always been checking for the request to be
settled, like for the header here – we show the "editing" items in the 3-dots menu based on this condition:App/src/components/MoneyRequestHeader.js
Line 88 in addfa88
And after canceling, the "Send" request becomes unsettled.
What changes do you think we should make in order to solve the problem?
I think it's important to differentiate all the IOU requests by populating their
transactionor the Money Request Report with aniouType(and maybe the requestType) when placing the request:App/src/CONST.ts
Lines 1172 to 1181 in d912bf1
And we should change the logic in places where we differentiated requests only by the
isSettledstatus to check theiouTypeas well.Otherwise, not only the unwanted items appear in the 3-dots menu but also the canceled "Send" IOU behaves as "Owes":
What alternative solutions did you explore? (Optional)
mountiny commentedon Dec 25, 2023
Reverting the original PR because it has caused numerous deploy blockers and the author is ooo
17 remaining items
melvin-bot commentedon Jan 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-25. 🎊
[-][HOLD for payment 2024-01-25] Cancel payment-Add receipt and Delete request options are present after canceling Send money payment[/-][+][HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment-Add receipt and Delete request options are present after canceling Send money payment[/+]melvin-bot commentedon Jan 19, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-26. 🎊
melvin-bot commentedon Feb 12, 2024
This issue has not been updated in over 15 days. @Gonals eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
melvin-bot commentedon Apr 25, 2024
@Gonals, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.