Skip to content

Update style for violations #33527

Closed
Closed

Description

@cead22
  • This is a followup to this PR Update MoneyRequestView.js to show Violations #32594
  • We need to update the styles of the violations messages such that they're aligned in the same wat as error messages in form input fields are aligned, and the hoverable styles match those of the input row when the input row has the cursor over it

@lindboe @trevor-coleman can you comment here for assignment please?
cc @Expensify/design

Issue OwnerCurrent Issue Owner: @cead22

Activity

  1. self-assigned this
    on Dec 22, 2023
  2. melvin-bot commented on Dec 22, 2023

    @melvin-bot

    Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

  3. cead22 commented on Dec 22, 2023

    @cead22
    ContributorAuthor

    I applied the design label for good measure, but I think you've already specified how things need to look in the linked PR

  4. aimane-chnaif commented on Dec 22, 2023

    @aimane-chnaif
    Contributor

    I'd be happy to take this as C+

  5. JaimisMiyani commented on Dec 23, 2023

    @JaimisMiyani

    Hello
    I would love to contribute. let me know if there is any issue.

    Thanks in advance.

  6. melvin-bot commented on Dec 23, 2023

    @melvin-bot

    📣 @JaimisMiyani! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  7. JaimisMiyani commented on Dec 23, 2023

    @JaimisMiyani

    Contributor details
    Your Expensify account email: jaimismiyani12@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~010843db372089015a

  8. melvin-bot commented on Dec 23, 2023

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  9. melvin-bot commented on Dec 26, 2023

    @melvin-bot

    @cead22, @dubielzyk-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. 21 remaining items

  11. melvin-bot commented on Feb 15, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @cead22, @dubielzyk-expensify eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  12. reopened this on Feb 16, 2024
  13. melvin-bot commented on Feb 16, 2024

    @melvin-bot
  14. cead22 commented on Feb 16, 2024

    @cead22
    ContributorAuthor

    @MitchExpensify can you please handle payment to @cubuspl42 for the review? Thanks!

  15. MitchExpensify commented on Feb 16, 2024

    @MitchExpensify
    Contributor
  16. jakub-trzebiatowski commented on Feb 19, 2024

    @jakub-trzebiatowski
    Contributor

    Accepted 👍

  17. MitchExpensify commented on Feb 22, 2024

    @MitchExpensify
    Contributor

    Paid and contract ended!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions