Skip to content

[HOLD for payment 2024-01-17] [$500] LHN - Red dot does not appear in LHN conversation when IOU deletion error occurs #33535

New issue
New issue
Closed
Closed
[HOLD for payment 2024-01-17] [$500] LHN - Red dot does not appear in LHN conversation when IOU deletion error occurs#33535
Assignees
robertjchenChristinadobrzynshubham1206agratienifr
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Description

@lanitochka17
lanitochka17
opened on Dec 23, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.16-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open New Expensify app
  2. Log in with any account
  3. Navigate to any conversation with an user you have access to and Request $10
  4. Disable the internet connection on the main testing device.
  5. As the secondary user/device navigate to the conversation with the main user where the 10$ were just requested
  6. As the Secondary user/device Pay the IOU via "Pay elsewhere"
  7. On the main testing device while offline - cancel the 10$ IOU
  8. Enable the internet connection on the main testing device
  9. Navigate to a paid IOU

Expected Result:

The red dot should appear in the LHN conversation when the error is caused by an offline deletion of a paid IOU

Actual Result:

A red dot does not appear in the LHN conversation when the error is caused by a paid IOU being removed offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6324507_1703287642404.Recording__969.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c5cf5023e3aab261
  • Upwork Job ID: 1738392838951575552
  • Last Price Increase: 2023-12-23
  • Automatic offers:
    • shubham1206agra | Reviewer | 28071466
    • tienifr | Contributor | 28071467

Activity

  1. lanitochka17
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 23, 2023
  2. melvin-bot
    changed the title [-]LHN - Red dot does not appear in LHN conversation when IOU deletion error occurs[/-] [+][$500] LHN - Red dot does not appear in LHN conversation when IOU deletion error occurs[/+] on Dec 23, 2023

  3. melvin-bot commented on Dec 23, 2023

    @melvin-bot
    melvin-botBot
    on Dec 23, 2023 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~01c5cf5023e3aab261

  4. melvin-bot
    assigned
    Christinadobrzyn
    on Dec 23, 2023

  5. melvin-bot commented on Dec 23, 2023

    @melvin-bot
    melvin-botBot
    on Dec 23, 2023 – with Melvin Bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 23, 2023

  7. melvin-bot commented on Dec 23, 2023

    @melvin-bot
    melvin-botBot
    on Dec 23, 2023 – with Melvin Bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

  8. melvin-bot commented on Dec 23, 2023

    @melvin-bot
    melvin-botBot
    on Dec 23, 2023 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

  9. melvin-bot
    assigned
    shubham1206agra
    on Dec 23, 2023

  10. tienifr commented on Dec 23, 2023

    @tienifr
    tienifr
    on Dec 23, 2023
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    A red dot does not appear in the LHN conversation when the error is caused by a paid IOU being removed offline

    What is the root cause of that problem?

    We're not setting the error message to the report preview action in Onyx in failureData when deleting money request. We did it when creating the money request here so it works fine in that case.

    What changes do you think we should make in order to solve the problem?

    Set the error message to the report preview action in Onyx in failureData when deleting money request, by updating this to:

    [reportPreviewAction.reportActionID]: {
    ...reportPreviewAction,
    errors: ErrorUtils.getMicroSecondOnyxError('iou.error.genericDeleteFailureMessage'),
},

    Currently even for other money request-related errors (like when creating money request fails), if we want to clear error by clicking "X", we have to clear errors individually in the report preview action and the IOU report. This will be the same for the delete money request error here.

    But if we want clearing by "X" at 1 place to clear in both places, we can do that as well (for example by updating clearReportActionErrors), because they'd share the same error key, just that they are in 2 different report actions.

    What alternative solutions did you explore? (Optional)

    Consider fixing the same for editing money request error and other types of money request-related operations.

    While testing I see there's sometimes an issue where if we reload the IOU report, the IOU report action disappears but the error in LHN still show. This is existing issue but seems out of scope of this issue but we might want to log and fix it.

  11. melvin-bot
    added
    Overdue
    on Dec 25, 2023

  12. melvin-bot commented on Dec 26, 2023

    @melvin-bot
    melvin-botBot
    on Dec 26, 2023 – with Melvin Bot

    @Christinadobrzyn, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  13. shubham1206agra commented on Dec 26, 2023

    @shubham1206agra
    shubham1206agra
    on Dec 26, 2023
    Contributor

    @tienifr Your proposal doesn't seem right in this case. Your RCA is correct but solution seems wrong

  14. 23 remaining items

  15. melvin-bot commented on Jan 10, 2024

    @melvin-bot
    melvin-botBot
    on Jan 10, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-01-17. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Jan 10, 2024

    @melvin-bot
    melvin-botBot
    on Jan 10, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
    • [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@shubham1206agra] Determine if we should create a regression test for this bug.
    • [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. melvin-bot
    added
    DailyKSv2
    Overdue
    and removed
    WeeklyKSv2
    on Jan 16, 2024

  18. robertjchen commented on Jan 19, 2024

    @robertjchen
    robertjchen
    on Jan 19, 2024
    Contributor

    Awaiting completion of BZ checklist 🙏

  19. melvin-bot
    added
    Overdue
    and removed
    Overdue
    on Jan 19, 2024
  20. robertjchen
    added
    ReviewingHas a PR in review
    on Jan 23, 2024
  21. melvin-bot
    removed
    Overdue
    on Jan 23, 2024

  22. shubham1206agra commented on Jan 23, 2024

    @shubham1206agra
    shubham1206agra
    on Jan 23, 2024
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  23. Christinadobrzyn commented on Jan 23, 2024

    @Christinadobrzyn
    Christinadobrzyn
    on Jan 23, 2024
    Contributor

    Sorry for the delay- paying this out.

    Payouts due:

    Issue Reporter: NA
    Contributor: $500 @tienifr (paid in Upwork)
    Contributor+: $500 @shubham1206agra (paid in Upwork)

    Eligible for 50% #urgency bonus? NA

    Upwork job is here.

    @shubham1206agra can you accept our offer in Upwork and I'll pay you? Thanks!

  24. shubham1206agra commented on Jan 23, 2024

    @shubham1206agra
    shubham1206agra
    on Jan 23, 2024
    Contributor

    Accepted

  25. Christinadobrzyn commented on Jan 26, 2024

    @Christinadobrzyn
    Christinadobrzyn
    on Jan 26, 2024
    Contributor

    Awesome! paid in Upwork based on this payment summary - #33535 (comment)

    Closing this out as complete! Thanks everyone!

  26. Christinadobrzyn
    closed this as completedon Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions