[$500] [MEDIUM] LHN - Green dot(IOU) disappears from WS conversation in LHN when going offline-online

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.16-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

⚠️ To reproduce you need an account that has the beta: excludedFromReliableUpdates.

Open New Expensify app
Log in with any account
Create new workspace
Request money on that workspace
Go to offline mode and after a few seconds return to online mode

Expected Result:

The IOU green dot must be present in the LHN in any mode of operation until the IOU request is paid or an IOU error occurs.

Actual Result:

The green dot IOU disappears from the LHN if the user goes offline and comes back online.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6324826_1703328627225.Recording__981.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019c2e500b47b7def2
Upwork Job ID: 1738525487918645248
Last Price Increase: 2024-01-31

Job added to Upwork: https://www.upwork.com/jobs/~019c2e500b47b7def2

@Christinadobrzyn

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@alitoshmatov

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

Issue is still reproducible on the latest build 1.4.40-1

Recording.1331.mp4

@lanitochka17

Well, that's strange. I tested it by trying both steps found here and here. I also tried it on multiple browsers just to be sure and I still couldn't reproduce the problem.

Maybe I'm missing something, or this is some edge case and we still haven't figured out all the necessary steps. I'm attaching a video of how it behaves for me (build 1.4.40-4) @lanitochka17 let me know if there's anything I have done incorrectly there.

For some reason I'm not being able to reproduce in main in my dev environment but I was able to reproduce in https://staging.new.expensify.com/

Screen.Recording.2024-02-13.at.11.14.10.AM.mov

@paultsimura

From looking at ReconnectApp and OpenReport response, I agree with @paultsimura 's findings here and it does look like ReconnectApp calculates hasOutstandingChildRequest incorrectly.

@BartoszGrajdek

Reproduced in dev, the key is that the account has to have the beta excludedFromReliableUpdates. Accounts under expensifail.com , applause.expensifail.com and some big domains have this, so I guess that explain why @BartoszGrajdek can't reproduce.

I have a fix here https://github.com/Expensify/Auth/pull/9929, I just need to add the tests and I'll make it ready for review

@aldo-expensify

Yay! Exciting @aldo-expensify!

PR was deployed

Tested and now it is working:

Screen.Recording.2024-02-14.at.12.42.17.PM.mov

In the video we can see that the policyExpenseChat (reportID: 2130476157825373) comes with hasOutstandingChildRequest: true in ReconnectApp

@aldo-expensify

hey @aldo-expensify or @alitoshmatov do we need to pay out anyone for this?

@Christinadobrzyn

@Christinadobrzyn not as far as I know, the backend PR wasn't reviewed by C+

Navigation Menu

Repository navigation

[$500] [MEDIUM] LHN - Green dot(IOU) disappears from WS conversation in LHN when going offline-online #33544

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

76 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$500] [MEDIUM] LHN - Green dot(IOU) disappears from WS conversation in LHN when going offline-online #33544

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 23, 2023

melvin-bot commented on Dec 23, 2023

melvin-bot commented on Dec 23, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Dec 23, 2023

76 remaining items

lanitochka17 commented on Feb 12, 2024

BartoszGrajdek commented on Feb 13, 2024

aldo-expensify commented on Feb 13, 2024

aldo-expensify commented on Feb 13, 2024

aldo-expensify commented on Feb 13, 2024

aldo-expensify commented on Feb 13, 2024

Christinadobrzyn commented on Feb 14, 2024

aldo-expensify commented on Feb 14, 2024

aldo-expensify commented on Feb 14, 2024

Christinadobrzyn commented on Feb 15, 2024

aldo-expensify commented on Feb 15, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions