Repository navigation
[$500] CRITICAL: Show Join button in header when hidden #33577
Description
Problem:
When you open a chat of any kind (eg, room, thread) you generally start out in the hidden notification frequency, meaning that you are just "previewing" the chat -- you haven't joined it, and once you leave it, you won't be notified of any updates. The most straightforward way to join a room is to post. However, you can also explicitly "join" -- and people often want to do so. However, our testing suggests that people have had trouble realizing that they hadn't joined, or that it was needed.
Solution:
Add a Join button to the right side of the header when viewing a room being previewed with with hidden notification frequency. This would look something like this, except with the button merely being Join (because this wouldn't just be shown for threads):
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01c2c22166cbdecd2b
- Upwork Job ID: 1739928998230241280
- Last Price Increase: 2023-12-27
- Automatic offers:
- abdulrahuman5196 | Reviewer | 28072883
- bernhardoj | Contributor | 28072884
Activity
melvin-bot commentedon Dec 26, 2023
Current assignee @srikarparsi is eligible for the Engineering assigner, not assigning anyone new.
srikarparsi commentedon Dec 27, 2023
Looked into this today and it seems pretty straightforward since we already have the structure setup in the MoneyReportHeader for the button in the header.
We just have to use a regular button with "Join" and add similar logic from MoneyReportHeader in HeaderView.
I'm going to make this external since it's purely frontend but will take it back up if there's no progress made by Friday so that it can be done on Monday.
melvin-bot commentedon Dec 27, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01c2c22166cbdecd2b
[-]CRITICAL: Show Join button in header when hidden[/-][+][$500] CRITICAL: Show Join button in header when hidden[/+]melvin-bot commentedon Dec 27, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (
External)37 remaining items
melvin-bot commentedon Jan 23, 2024
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.srikarparsi commentedon Jan 23, 2024
Hey @MitchExpensify! Do you think you could help with paying @abdulrahuman5196 and @bernhardoj for this PR whenever you have a chance?
MitchExpensify commentedon Jan 24, 2024
Payment summary:
Offers sent! https://www.upwork.com/jobs/~01a8693a9be92d03bf
melvin-bot commentedon Jan 30, 2024
@MitchExpensify, @abdulrahuman5196, @srikarparsi, @bernhardoj Eep! 4 days overdue now. Issues have feelings too...
abdulrahuman5196 commentedon Jan 30, 2024
@MitchExpensify Could you kindly process payment for this issue?
MitchExpensify commentedon Jan 30, 2024
Done! Sorry for the delay