Repository navigation
[HOLD for payment 2024-01-31] [$500] Mention - Only 3 user are scrollable when use keyboard to pick user to mention #33613
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.17-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal
Slack conversation:
Action Performed:
Precondition:
Connect the pc keyboard to mobile device
Steps:
- Navigate to staging.new.expensify.com
- Go to any chat
- Start texting until chat is expanded
- Type @ to open mention member list
- Use keyboard arrows to scroll through the list
Expected Result:
User should be able to navigate to all members in the list
Actual Result:
When using keyboard arrows user is able to scroll only 3 members from the list
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6326341_1703616195297.Recording__1643.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~017bdddeb3dc37e5c7
- Upwork Job ID: 1739721691952898048
- Last Price Increase: 2024-01-09
- Automatic offers:
- mkhutornyi | Contributor | 28095701
Activity
[-]Mention - Only 3 user are scrollable when use keyboard to pick user to mention[/-][+][$500] Mention - Only 3 user are scrollable when use keyboard to pick user to mention[/+]melvin-bot commentedon Dec 26, 2023
Job added to Upwork: https://www.upwork.com/jobs/~017bdddeb3dc37e5c7
melvin-bot commentedon Dec 26, 2023
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 26, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Dec 26, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)mkhutornyi commentedon Dec 26, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Mention - Only 3 user are scrollable when use keyboard to pick user to mention
This happens on emoji suggestion as well
What is the root cause of that problem?
App/src/libs/SuggestionUtils.js
Line 9 in 64a88e4
Here, we're getting max arrow index from 2 factors: list size and
isAutoSuggestionPickerLargeSo if
isAutoSuggestionPickerLarge= false and list size > 3, this function always returns 3, ignoring list size. And this setsmaxIndexof arrow focus manager to 3.What changes do you think we should make in order to solve the problem?
arrow max index should not depend on visible size as it's scrollable
So replace this line with
maxIndex: suggestionValues.suggestedMentions.length - 1App/src/pages/home/report/ReportActionCompose/SuggestionMention.js
Line 62 in 64a88e4
Same applies to SuggestionEmoji
rrrshtt commentedon Dec 26, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Suggestions stacked in 3 items with keyboard control.
What is the root cause of that problem?
App/src/libs/SuggestionUtils.js
Line 9 in 2b58e1c
App/src/pages/home/report/ReportActionCompose/SuggestionMention.js
Line 62 in 2b58e1c
The entire
function getMaxArrowIndex()is incorrect for this purpose since it's a keyboard controller.What changes do you think we should make in order to solve the problem?
We can simply use the length of suggested mentions in the keyboard controller because we only need the total number of items in the hook.
melvin-bot commentedon Dec 26, 2023
📣 @rrrshtt! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
rrrshtt commentedon Dec 26, 2023
Contributor details
Your Expensify account email: mrishat03@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~012f657c01285b6cf0
42 remaining items
[-][$500] Mention - Only 3 user are scrollable when use keyboard to pick user to mention[/-][+][HOLD for payment 2024-01-31] [$500] Mention - Only 3 user are scrollable when use keyboard to pick user to mention[/+]melvin-bot commentedon Jan 24, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 24, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.30-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-31. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 24, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
CortneyOfstad commentedon Jan 31, 2024
Payment Summary
@mkhutornyi (Contributor) — paid $500 via Upwork
@eVoloshchak (C+) — to be paid $500 via New Dot
CortneyOfstad commentedon Jan 31, 2024
@eVoloshchak any update on the checklist above? Thanks!
CortneyOfstad commentedon Feb 1, 2024
@eVoloshchak just bumping on the checklist so we can get this closed. Thanks!
eVoloshchak commentedon Feb 3, 2024
Is it easy to test for this bug? No, this requires an Android device with a physical keyboard connected to test
Is the bug related to an important user flow? No
Is it an impactful bug? No
We don't need a regression test here, the bug is rare and isn't impactful, and it might be hard for QA to test
eVoloshchak commentedon Feb 3, 2024
Requested the payment
JmillsExpensify commentedon Feb 3, 2024
$500 approved for @eVoloshchak based on summary above.
CortneyOfstad commentedon Feb 5, 2024
Thanks all!