Skip to content

HIGH: Add a system message in the corresponding room when a room description is edited #33736

Closed

Description

@quinthar

Problem:
We are going to be allow anyone to edit the room's description, which is ripe for abuse.

Solution:
Post a system message from the editor whenever the the room description is changed.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a15953af69385546
  • Upwork Job ID: 1740532798842871808
  • Last Price Increase: 2023-12-29

Activity

  1. converted this from a draft issue on Dec 29, 2023
  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 29, 2023
  3. melvin-bot commented on Dec 29, 2023

    @melvin-bot
  4. changed the title [-]HIGH: Add a system message in the corresponding room when a room description is edited[/-] [+][$500] HIGH: Add a system message in the corresponding room when a room description is edited[/+] on Dec 29, 2023
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 29, 2023
  6. melvin-bot commented on Dec 29, 2023

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. melvin-bot commented on Dec 29, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  8. melvin-bot commented on Dec 29, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

  9. quinthar commented on Dec 29, 2023

    @quinthar
    ContributorAuthor

    Oh shit, this actually can't be done externally, nm!! Call off the cavalry!!

  10. 9 remaining items

  11. puneetlath commented on Feb 7, 2024

    @puneetlath
    Contributor

    Planning to add this next.

  12. puneetlath commented on Feb 14, 2024

    @puneetlath
    Contributor
  13. puneetlath commented on Feb 16, 2024

    @puneetlath
    Contributor

    Order of operation:

  14. puneetlath commented on Feb 21, 2024

    @puneetlath
    Contributor

    The Auth PR is merged, but not deployed. The Web PR will get merged once the Auth PR is deployed. Will likely be done early next week given the merge freeze.

  15. puneetlath commented on Feb 29, 2024

    @puneetlath
    Contributor

    This is all done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions