Skip to content

[$500] IOU - 'You marked this report...' message only appears on the second visit to IOU report #34003

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. From user A, make an IOU request to user B
  2. Sign in with user B
  3. Open the IOU request from user A
  4. Click on the IOU preview component
  5. Click on 'Pay elsewhere' button
  6. Navigate back to the parent report
  7. Click on the IOU preview component of the settled request

Expected Result:

'You marked this report as manually reimbursed. This report will be reimbursed outside of Expensify' should be displayed in IOU report on step 5

Actual Result:

'You marked this report as manually reimbursed. This report will be reimbursed outside of Expensify' is displayed in IOU report in step 7

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6332692_1704416150287.Screen_Recording_2024-01-05_at_1.15.56_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01913119946e4f8e1d
  • Upwork Job ID: 1743143357085888512
  • Last Price Increase: 2024-01-05

Activity

  1. github-actions commented on Jan 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jan 5, 2024

    @melvin-bot

    Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. jasperhuangg commented on Jan 5, 2024

    @jasperhuangg
    Contributor

    This appears to be a back-end issue. It seems like we're notifying of the latest IOU action paid $XXX elsewhere here, but we're not notifying of the MARK_REIMBURSED action.

  4. added
    InternalRequires API changes or must be handled by Expensify staff
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 5, 2024
  5. melvin-bot commented on Jan 5, 2024

    @melvin-bot
  6. melvin-bot commented on Jan 5, 2024

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @shubham1206agra (Internal)

  7. 72 remaining items

  8. brunovjk commented on Feb 20, 2024

    @brunovjk
    Contributor

    I'm still waiting for confirmation to start. Thanks.

  9. jasperhuangg commented on Feb 20, 2024

    @jasperhuangg
    Contributor

    @brunovjk go for it! You've been assigned to the issue.

  10. brunovjk commented on Feb 21, 2024

    @brunovjk
    Contributor

    Sorry, I hadn't noticed, let's get to work :D thank you @jasperhuangg

  11. brunovjk commented on Feb 21, 2024

    @brunovjk
    Contributor

    PR ready for review.

  12. brunovjk commented on Mar 12, 2024

    @brunovjk
    Contributor

    @jasperhuangg and @bfitzexpensify Can you confirm if this issue/PR is valid for payment? Thanks.

  13. jasperhuangg commented on Mar 12, 2024

    @jasperhuangg
    Contributor

    @brunovjk ah yes, sorry I think our automated messages were broken for a bit– @bfitzexpensify do you mind handling payouts here? We need to pay out @brunovjk for implementing the fix and @akinwale for PR review

  14. bfitzexpensify commented on Mar 13, 2024

    @bfitzexpensify
    Contributor

    You bet - offers sent @brunovjk and @akinwale

  15. akinwale commented on Mar 13, 2024

    @akinwale
    Contributor

    @bfitzexpensify Accepted. Thanks!

  16. brunovjk commented on Mar 13, 2024

    @brunovjk
    Contributor

    Accepted. Thanks!

  17. bfitzexpensify commented on Mar 13, 2024

    @bfitzexpensify
    Contributor

    Great - all paid out. Apologies for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringHelp WantedApply this label when an issue is open to proposals by contributorsInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions