You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-17] Chat - App crashes after opening image preview and tapping back button #34017
Version Number: 1.4.22-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Go to the chat where you have sent the PDF file
Send any image
Tap on the image preview
Tap on the back button
Expected Result:
User should be taken to the chat page without any issues
Actual Result:
The app crashes after tapping on back button
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@aldo-expensify I suggest to downgrade react-native-pdf version to 6.7.3 for now, rather than any patch.
We can bump again once this is fixed in upstream.
changed the title [-]Chat - App crashes after opening image preview and tapping back button[/-][+][HOLD for payment 2024-01-17] Chat - App crashes after opening image preview and tapping back button[/+]on Jan 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aldo-expensify] The PR that introduced the bug has been identified. Link to the PR:
[@aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aldo-expensify] Determine if we should create a regression test for this bug.
[@aldo-expensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jan 5, 2024
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jan 5, 2024
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)github-actions commentedon Jan 5, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jan 5, 2024
Triggered auto assignment to @aldo-expensify (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.situchan commentedon Jan 5, 2024
regression from #33561
situchan commentedon Jan 5, 2024
upstream issue: wonday/react-native-pdf#796
@aldo-expensify I suggest to downgrade react-native-pdf version to 6.7.3 for now, rather than any patch.
We can bump again once this is fixed in upstream.
melvin-bot commentedon Jan 5, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
marcaaron commentedon Jan 5, 2024
Let's close this as a dupe of #34047
[-]Chat - App crashes after opening image preview and tapping back button[/-][+][HOLD for payment 2024-01-17] Chat - App crashes after opening image preview and tapping back button[/+]melvin-bot commentedon Jan 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-17. 🎊
melvin-bot commentedon Jan 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: