[HOLD for payment 2024-02-07] [$500] Reimbursement - Reimbursement message is not copied with "Copy to clipboard"

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

[User A] Request money from User B
[User B] Pay the request
[User A] Go to the paid IOU report
[User A] Right click on reimbursement message > Copy to clipboard
[User A] Paste the content

Expected Result:

The reimbursement message is copied successfully

Actual Result:

The reimbursement message is not copied

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6333354_1704475020941.20240105_085906.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01143d94d68559e19a
Upwork Job ID: 1743429727276658688
Last Price Increase: 2024-01-13

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@tylerkaraszewski

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Can not copy message reimbursement

What is the root cause of that problem?

We do not have a logic for copying the type "MARKEDREIMBURSED" of message in here

What changes do you think we should make in order to solve the problem?

We should add logic like this

if (reportAction.actionName === 'MARKEDREIMBURSED') {
 const reimbursMementessage = _.reduce(reportAction.message, (acc, curr) => `${acc}${curr.text}`, '');
 Clipboard.setString(reimbursMementessage);
}

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reimbursement message is not copied with "Copy to clipboard"

What is the root cause of that problem?

We did not cover the case of MARKEDREIMBURSED here.

What changes do you think we should make in order to solve the problem?

We should add the check to cover reimbursement message type:

if (reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.MARKEDREIMBURSED) {
    const message = ReportActionsUtils.getMarkedReimbursedMessage(reportAction);
    Clipboard.setString(message);
}

We should cover other cases of reimbursement messages like REIMBURSEMENTDEQUEUED or REIMBURSEMENTQUEUED as well.

What alternative solutions did you explore? (Optional)

I also notice that the TS definition here is insufficient. We should supplement all types of messages to avoid type errors.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copying reimbursed system message copies nothing.

What is the root cause of that problem?

The reimbursed system message object only contains text property and not html.

When we press copy to clipboard, we only take the last message html.

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 33 to 36 in a8acf44

    
           function getActionText(reportAction: OnyxEntry<ReportAction>): string { 
        
               const message = reportAction?.message?.at(-1) ?? null; 
        
               return message?.html ?? ''; 
        
           }

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Line 298 in a8acf44

    
           const messageHtml = isTaskAction ? TaskUtils.getTaskReportActionMessage(reportAction?.actionName) : getActionText(reportAction);

So, the copy to clipboard fails to copy the message.

What changes do you think we should make in order to solve the problem?

Previously, we had a similar issue for SUBMITTED action and the solution is to concat all message text.

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 324 to 327 in a8acf44

    
           } else if (ReportActionsUtils.isSubmittedExpenseAction(reportAction)) { 
        
               const submittedMessage = reportAction?.message?.reduce((acc, curr) => `${acc}${curr.text}`, ''); 
        
               Clipboard.setString(submittedMessage ?? ''); 
        
           } else if (content) {

But instead of handling it case by case, we can make it a general case. So, in addition to messageHtml, we can create messageText which is the result of all the messages' concatenation. Then, we will use it as the last fallback.

const messageText = reportAction?.message?.reduce((acc, curr) => `${acc}${curr.text}`, '');

} else if (messageText) {
    Clipboard.setString(messageText)
}

Job added to Upwork: https://www.upwork.com/jobs/~01143d94d68559e19a

@muttmuure

Issue is ready for payment but no BZ is assigned. @muttmuure you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@fedirjh

Payment Summary

Upwork Job

ROLE: @fedirjh paid $(AMOUNT) via Upwork (LINK)
ROLE: @bernhardoj paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@muttmuure)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1743429727276658688/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@muttmuure

@muttmuure C+ payment should be issued to @0xmiroslav as he has fully reviewed the PR.

@0xmiroslav

Invited @0xmiroslav and @bernhardoj

@tylerkaraszewski

@tylerkaraszewski, @fedirjh, @muttmuure, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@bernhardoj

Offer sent to @bernhardoj

@0xmiroslav

Waiting for @0xmiroslav to accept

@0xmiroslav

Going to close for now, @0xmiroslav please reopen when you'd like to be paid

@muttmuure

@muttmuure Hi, I was scanning through my pending payment and saw that I haven't been paid yet on this one. Here is the offer that I was checking, could you kindly check it on your side?

@bernhardoj

Contributor: @bernhardoj paid $500 via Upwork
Sorry we missed that @bernhardoj

@mallenexpensify

@mallenexpensify Thanks!

Navigation Menu

Repository navigation

[HOLD for payment 2024-02-07] [$500] Reimbursement - Reimbursement message is not copied with "Copy to clipboard" #34045

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

52 remaining items

Payment Summary

BugZero Checklist (@muttmuure)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function getActionText(reportAction: OnyxEntry<ReportAction>): string {
	const message = reportAction?.message?.at(-1) ?? null;
	return message?.html ?? '';
	}

	} else if (ReportActionsUtils.isSubmittedExpenseAction(reportAction)) {
	const submittedMessage = reportAction?.message?.reduce((acc, curr) => `${acc}${curr.text}`, '');
	Clipboard.setString(submittedMessage ?? '');
	} else if (content) {

[HOLD for payment 2024-02-07] [$500] Reimbursement - Reimbursement message is not copied with "Copy to clipboard" #34045

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Jan 5, 2024

melvin-bot commented on Jan 5, 2024

namhihi237 commented on Jan 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

gijoe0295 commented on Jan 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

bernhardoj commented on Jan 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Jan 6, 2024

52 remaining items

melvin-bot commented on Feb 7, 2024

melvin-bot commented on Feb 7, 2024

Payment Summary

BugZero Checklist (@muttmuure)

fedirjh commented on Feb 7, 2024

muttmuure commented on Feb 9, 2024

melvin-bot commented on Feb 12, 2024

muttmuure commented on Feb 12, 2024

muttmuure commented on Feb 12, 2024

muttmuure commented on Feb 13, 2024

bernhardoj commented on Apr 9, 2024

mallenexpensify commented on Apr 9, 2024

bernhardoj commented on Apr 10, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions