Skip to content

[Hold for #34409] [$500] Android - Public room - Extra spacing above the room header #34050

New issue
New issue
Closed
Closed
[Hold for #34409] [$500] Android - Public room - Extra spacing above the room header#34050
Assignees
blimpichgreg-schroedersituchan
Labels
BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Description

@lanitochka17
lanitochka17
opened on Jan 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33829

Action Performed:

  1. Log out.
  2. Tap on public room link on a different app. (https://staging.new.expensify.com/r/2376199970894587)
  3. Log in to any account

Expected Result:

The room header has adequate spacing

Actual Result:

There is extra spacing above the room header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333402_1704477952176!Screenshot_20240106_020324

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011fc3d6204dc1c3d6
  • Upwork Job ID: 1745516903101734912
  • Last Price Increase: 2024-01-18

Activity

  1. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 5, 2024
  2. github-actions
    added
    Engineering
    HourlyKSv2
    on Jan 5, 2024

  3. github-actions commented on Jan 5, 2024

    @github-actions
    github-actionsBot
    on Jan 5, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot
    assigned
    blimpich
    on Jan 5, 2024

  5. melvin-bot commented on Jan 5, 2024

    @melvin-bot
    melvin-botBot
    on Jan 5, 2024 – with Melvin Bot

    Triggered auto assignment to @blimpich (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. blimpich commented on Jan 5, 2024

    @blimpich
    blimpich
    on Jan 5, 2024
    Contributor

    I don't consider this a blocker, considering it only occurs on Android, is a fairly minor UI mishap, and only happens under very specific circumstances.

  7. blimpich
    added
    DailyKSv2
    Help WantedApply this label when an issue is open to proposals by contributors
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Jan 5, 2024

  8. melvin-bot commented on Jan 5, 2024

    @melvin-bot
    melvin-botBot
    on Jan 5, 2024 – with Melvin Bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  9. melvin-bot
    assigned
    greg-schroeder
    on Jan 5, 2024

  10. melvin-bot commented on Jan 5, 2024

    @melvin-bot
    melvin-botBot
    on Jan 5, 2024 – with Melvin Bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

  11. 46 remaining items

  12. melvin-bot
    removed
    Overdue
    on Feb 26, 2024

  13. greg-schroeder commented on Mar 2, 2024

    @greg-schroeder
    greg-schroeder
    on Mar 2, 2024
    Contributor

    PR was merged and deployed to prod

  14. greg-schroeder
    added
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    on Mar 2, 2024

  15. greg-schroeder commented on Mar 2, 2024

    @greg-schroeder
    greg-schroeder
    on Mar 2, 2024
    Contributor

    Let's retest to see if it works - I can't test this personally cause I don't have an android device, asking QA

  16. melvin-bot
    added
    Overdue
    on Mar 11, 2024

  17. greg-schroeder commented on Mar 13, 2024

    @greg-schroeder
    greg-schroeder
    on Mar 13, 2024
    Contributor

    Will bump QA

  18. melvin-bot
    removed
    Overdue
    on Mar 13, 2024

  19. mvtglobally commented on Mar 14, 2024

    @mvtglobally
    mvtglobally
    on Mar 14, 2024

    Issue not reproducible during KI retests. (First week)

  20. situchan commented on Mar 14, 2024

    @situchan
    situchan
    on Mar 14, 2024
    Contributor

    Looks like deep link is broken.
    I am not able to go to public room with anonymous user on android phone. Stuck on login.

  21. mvtglobally commented on Mar 20, 2024

    @mvtglobally
    mvtglobally
    on Mar 20, 2024

    Issue not reproducible during KI retests. (Second week)

  22. melvin-bot
    added
    Overdue
    on Mar 25, 2024

  23. greg-schroeder commented on Mar 25, 2024

    @greg-schroeder
    greg-schroeder
    on Mar 25, 2024
    Contributor

    I think I'm going to close this as QA can't repro

  24. greg-schroeder
    closed this as completedon Mar 25, 2024
  25. melvin-bot
    removed
    Overdue
    on Mar 25, 2024

  26. greg-schroeder commented on Mar 25, 2024

    @greg-schroeder
    greg-schroeder
    on Mar 25, 2024
    Contributor

    Reopen if you disagree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions