[HOLD for payment 2024-02-15] [$500] Task - Task assigned to "Hidden" does not show "Hidden" as assignee in main chat

@stephanieelliott

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #29730

Action Performed:

Go to FAB > Assign task
Enter title > Next
Click Assignee
Enter a valid email with no display name that is registered on ND but has no chat history with the user
(use yonghongkok2+03011@gmail.com
)
Create the task

Expected Result:

The task preview in the main chat will show "Hidden" as the assignee

Actual Result:

The task preview in the main chat does not show "Hidden" as the assignee

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6333411_1704479061341.20240105_195946__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e3fabdb897c1d05d
Upwork Job ID: 1744829796306513920
Last Price Increase: 2024-01-16
Automatic offers:

hoangzinh | Contributor | 28116810
dukenv0307 | Contributor | 28117853

Issue Owner

Current Issue Owner: @stephanieelliott

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@grgia

Triggered auto assignment to @grgia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal

from: @unicorndev-727

Please re-state the problem that we are trying to solve in this issue.

Task - Task assigned to "Hidden" does not show "Hidden" as assignee in main chat

What is the root cause of that problem?

This is not deploy blocker, I think (I can't find relevant PR for this issue in Deploy checklist).
The root cause is that we didn't use getDisplayNameForParticipant here.

App/src/components/ReportActionItem/TaskPreview.js

Line 99 in 7ae1ec7

    
           const taskAssignee = assigneeDisplayName || LocalePhoneNumber.formatPhoneNumber(assigneeLogin);

What changes do you think we should make in order to solve the problem?

We should use getDisplayNameForParticipant.

const taskAssignee = ReportUtils.getDisplayNameForParticipant(taskAssigneeAccountID);

What alternative solutions did you explore?

N/A

Still repro on build 1.4.22-2

Recording.898.mp4

Reviewing label has been removed, please complete the "BugZero Checklist".

@hoangzinh

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Refactor task preview for hidden case #35027

If no regressions arise, payment will be issued on 2024-02-15. 🎊

For reference, here are some details about the assignees on this issue:

@hoangzinh requires payment automatic offer (Contributor)
@dukenv0307 requires payment automatic offer (Contributor)

@hoangzinh

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
[@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hoangzinh] Determine if we should create a regression test for this bug.
[@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

^^ was tested and found to be NAB!

@dukenv0307

Summarizing payment on this issue:

Contributor: @dukenv0307 $500, paid via Upwork
Contributor+: @hoangzinh $500, paid via Upwork

Upwork job is here: https://www.upwork.com/jobs/~1737876297360310272"

Navigation Menu

Repository navigation

[HOLD for payment 2024-02-15] [$500] Task - Task assigned to "Hidden" does not show "Hidden" as assignee in main chat #34052

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore?

46 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-02-15] [$500] Task - Task assigned to "Hidden" does not show "Hidden" as assignee in main chat #34052

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Jan 5, 2024

melvin-bot commented on Jan 5, 2024

unidev727 commented on Jan 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore?

mvtglobally commented on Jan 7, 2024

46 remaining items

melvin-bot commented on Feb 8, 2024

melvin-bot commented on Feb 8, 2024

melvin-bot commented on Feb 8, 2024

melvin-bot commented on Feb 12, 2024

stephanieelliott commented on Feb 16, 2024

stephanieelliott commented on Feb 16, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions