You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-25] [$500] Room - No Join button in thread header for thread with no reply #34054
Version Number: 1.4.22-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
changed the title [-]Room - No Join button in thread header for thread with no reply[/-][+][$500] Room - No Join button in thread header for thread with no reply[/+]on Jan 5, 2024
There is another issue that the "Join" button is visible for an optimistic thread (can be tested via sending a new message and opening it as a thread all in offline mode). This is because the new threads are created with Hidden notification preference, but the API response returns Always:
To fix the optimistic thread issue, we should set the optimistic notification preference to "Always", if the user is the author of the original message, when clicking "Reply in thread" (i.e. creating a new thread) for the first time. It is replaced with "Always" on the API response if requested by the message author, and we're doing the same check do it when subscribing to the thread:
changed the title [-][$500] Room - No Join button in thread header for thread with no reply[/-][+][HOLD for payment 2024-01-25] [$500] Room - No Join button in thread header for thread with no reply[/+]on Jan 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
[@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Ollyws] Determine if we should create a regression test for this bug.
[@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR:
This behaviour was introduced in #27748 but there was reasoning behind it, so I'm not sure if this can really be defined as a bug it's more of a new feature.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
N/A
Determine if we should create a regression test for this bug.
Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
1. Go to any chat
2. Send a message
3. Right-click on the message > Unsubscribe from thread
4. Right-click on the message > Reply in the thread
5. Verify the "Join" button is present in the Header
Activity
[-]Room - No Join button in thread header for thread with no reply[/-][+][$500] Room - No Join button in thread header for thread with no reply[/+]melvin-bot commentedon Jan 5, 2024
Triggered auto assignment to @sophiepintoraetz (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jan 5, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01e0087435438fe2da
melvin-bot commentedon Jan 5, 2024
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Jan 5, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)paultsimura commentedon Jan 5, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
No "Join" button is displayed on the empty thread header
What is the root cause of that problem?
When showing the "Join" button, we check the thread to be not empty:
App/src/pages/home/HeaderView.js
Lines 156 to 158 in fb0b1d1
There is another issue that the "Join" button is visible for an optimistic thread (can be tested via sending a new message and opening it as a thread all in offline mode). This is because the new threads are created with
Hiddennotification preference, but the API response returnsAlways:App/src/libs/actions/Report.ts
Line 742 in 596e56b
What changes do you think we should make in order to solve the problem?
Remove the
!isEmptyChatcheck:To fix the optimistic thread issue, we should set the optimistic notification preference to "Always", if the user is the author of the original message, when clicking "Reply in thread" (i.e. creating a new thread) for the first time. It is replaced with "Always" on the API response if requested by the message author, and we're doing the same check do it when subscribing to the thread:
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Lines 176 to 177 in e18b1d0
Therefore, this change will make the optimistic match the actual BE response.
We should change the following line (742):
App/src/libs/actions/Report.ts
Lines 732 to 745 in 596e56b
What alternative solutions did you explore? (Optional)
paultsimura commentedon Jan 5, 2024
@srikarparsi could you please share why you decided to hide the "Join" button on the empty threads here?
samilabud commentedon Jan 5, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Room - No Join button in thread header for thread with no reply
What is the root cause of that problem?
When we reply in the same thread and we are unsubscribed we do not take into consideration if the parent's response is empty to show the join button.
What changes do you think we should make in order to solve the problem?
We should take into consideration if the parent message is empty or not to show the join button:
Result:
Join.button.in.thread.test.mp4
aim-salam commentedon Jan 6, 2024
.
18 remaining items
[-][$500] Room - No Join button in thread header for thread with no reply[/-][+][HOLD for payment 2024-01-25] [$500] Room - No Join button in thread header for thread with no reply[/+]melvin-bot commentedon Jan 18, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-25. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 18, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sophiepintoraetz commentedon Jan 30, 2024
@paultsimura - you're all paid - @Ollyws , I'll release payment once the BZ checklist is complete!
Ollyws commentedon Jan 30, 2024
BugZero Checklist:
This behaviour was introduced in #27748 but there was reasoning behind it, so I'm not sure if this can really be defined as a bug it's more of a new feature.
N/A
N/A
Yes
Regression Test Proposal
Do we agree 👍 or 👎
sophiepintoraetz commentedon Jan 31, 2024
Awesome, thanks @Ollyws! I need you to accept the offer though before I pay
https://www.upwork.com/nx/wm/offer/28093246
Ollyws commentedon Jan 31, 2024
Accepted, thanks.