You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Tax - Selecting tax after refreshing tax rate redirects user to request page #34058
Version Number: 1.4.22-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@lanitochka17 it seems like entering the tax information is also part of payment request creation while the payment was still not created by the time refresh was clicked. Since it was not saved for the same reason it was again landing on the payment request creation after the refresh.
Is it Really an issue?
📣 @MIAhmed! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
What changes do you think we should make in order to solve the problem?
We need to consider backTo param from the route as a fallback route and we can remove other unneeded params. Also apply the same fix for the IOURequestStepTaxAmountPage.
This is stemming from a new feature, which I'm not sure is intended to be complete at this stage or not (but I am guessing not). It's also a relative edge case. So I'm going to remove the deploy blocker label.
@MonilBhavsar@teneeto would y'all like to take this issue over since it's related to your feature build?
This issue has not been updated in over 15 days. @amyevans, @teneeto eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
github-actions commentedon Jan 5, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jan 5, 2024
Triggered auto assignment to @amyevans (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MIAhmed commentedon Jan 5, 2024
@lanitochka17 it seems like entering the tax information is also part of payment request creation while the payment was still not created by the time refresh was clicked. Since it was not saved for the same reason it was again landing on the payment request creation after the refresh.
Is it Really an issue?
melvin-bot commentedon Jan 5, 2024
📣 @MIAhmed! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
melvin-bot commentedon Jan 5, 2024
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
Pujan92 commentedon Jan 5, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Incorrect page opens on going back from tax page after refresh
What is the root cause of that problem?
We are providing the wrong fallback route for the tax pages. PR
App/src/pages/iou/request/step/IOURequestStepTaxRatePage.js
Line 63 in f5a3c02
App/src/pages/iou/request/step/IOURequestStepTaxRatePage.js
Line 76 in f5a3c02
What changes do you think we should make in order to solve the problem?
We need to consider
backToparam from the route as a fallback route and we can remove other unneeded params. Also apply the same fix for theIOURequestStepTaxAmountPage.Add
backTohere.App/src/pages/iou/request/step/IOURequestStepTaxRatePage.js
Line 55 in f5a3c02
Provide below fallback route for navigation goBack.
amyevans commentedon Jan 5, 2024
This is stemming from a new feature, which I'm not sure is intended to be complete at this stage or not (but I am guessing not). It's also a relative edge case. So I'm going to remove the deploy blocker label.
@MonilBhavsar @teneeto would y'all like to take this issue over since it's related to your feature build?
teneeto commentedon Jan 8, 2024
Hi @amyevans I can look into this. cc @MonilBhavsar
teneeto commentedon Jan 8, 2024
@amyevans kindly assign this to me. This is fixed in a follow-up Draft PR 33927
MonilBhavsar commentedon Jan 8, 2024
@teneeto assigned you to the issue
teneeto commentedon Jan 8, 2024
@MonilBhavsar @amyevans Opened a PR for this.
MonilBhavsar commentedon Jan 8, 2024
PR is merged. We can close this once the PR is deployed to production
melvin-bot commentedon Jan 31, 2024
This issue has not been updated in over 15 days. @amyevans, @teneeto eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
amyevans commentedon Jan 31, 2024
Whoops, PR deployed a while ago, closing now.