Skip to content

[$500] IOU - Back button brings user to infinite-loading page after deleting request with message #34059

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to 1:1 DM
  2. Create a manual request
  3. Go to details page
  4. Change the amount
  5. Delete the request
  6. Tap back button on the top left corner
  7. Tap back button again

Expected Result:

In Step 6, user is redirected to LHN

Actual Result:

In Step 6, user is redirected to a page which loads infinitely.
When tapping back button again (Step 7), user is still redirected to the same infinitely loading page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333451_1704482985896.RPReplay_Final1704446733__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c79b49baf6c222ef
  • Upwork Job ID: 1743366166366109696
  • Last Price Increase: 2024-01-12

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 5, 2024
  2. melvin-bot commented on Jan 5, 2024

    @melvin-bot
  3. changed the title [-] IOU - Back button brings user to infinite-loading page after deleting request with message[/-] [+][$500] IOU - Back button brings user to infinite-loading page after deleting request with message[/+] on Jan 5, 2024
  4. melvin-bot commented on Jan 5, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 5, 2024
  6. melvin-bot commented on Jan 5, 2024

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Jan 5, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  8. codebycarlos commented on Jan 6, 2024

    @codebycarlos

    This doesn't seem to be an issue on the latest main branch. Only staging. It is fixed by #32543 (merged into main yesterday). This line change in particular is responsible:

    From:

    const shouldDeleteTransactionThread = transactionThreadID ? ReportActionsUtils.getLastVisibleMessage(transactionThreadID).lastMessageText.length === 0 : false;

    To:

    const shouldDeleteTransactionThread = transactionThreadID ? lodashGet(reportAction, 'childVisibleActionCount', 0) === 0 : false;

    Could someone else please double check and if confirmed should we close the issue?

  9. brunovjk commented on Jan 7, 2024

    @brunovjk
    Contributor

    Could someone else please double check and if confirmed should we close the issue?

    I followed the steps to reproduce, if you do it slowly, giving time to receive the 'responses', it is not possible to reproduce, but if you do all the 'steps' quickly, without giving time to receive the 'responses', we have an error. @codebycarlos can you test and confirm for me please? Thanks.

  10. parasharrajat commented on Jan 8, 2024

    @parasharrajat
    Member

    @lanitochka17 Can you please retest this?

  11. lanitochka17 commented on Jan 8, 2024

    @lanitochka17
    Author

    Reproducible on v1.4.22-2

    RPReplay_Final1704736969.MP4
  12. codebycarlos commented on Jan 9, 2024

    @codebycarlos

    I'm not able to replicate this on v1.4.23-1.

    Web

    Screen.Recording.2024-01-09.at.10.10.53.pm.mov

    Android

    Screen.Recording.2024-01-09.at.10.07.42.pm.mov
  13. melvin-bot commented on Jan 11, 2024

    @melvin-bot

    @parasharrajat, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  14. melvin-bot commented on Jan 12, 2024

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  15. melvin-bot commented on Jan 12, 2024

    @melvin-bot

    @parasharrajat, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. adelekennedy commented on Jan 12, 2024

    @adelekennedy
    Contributor

    I also can't reproduce, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions