[$500] [HOLD for payment 2024-01-17] Expense - App crashes when attempting to request money from a deleted workspace

@marcaaron

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: User is an employee of a Collect workspace on Old Dot

[Employee] Go to workspace chat
[Admin] Delete the workspace on Old Dot
[Employee] Click + > Request money
[Employee] Enter amount > Next

Expected Result:

App does not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6333470_1704484833865.20240105_134408.mp4

logs.txt

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @marcaaron

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018ed1f3e02054d0aa
Upwork Job ID: 1747946417104683008
Last Price Increase: 2024-01-18

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@marcaaron

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes on request money flow for the deleted workspace report

What is the root cause of that problem?

Once workspace gets deleted, the policy will be removed from the onyx and it will be undefined. Here we are trying to access value from undefined which causing the crash. Regression from PR

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Line 280 in cb00747

const shouldShowTax = isPolicyExpenseChat && policy.isTaxTrackingEnabled;

What changes do you think we should make in order to solve the problem?

We need to safely access the field by checking the policy first to avoid this issue.

@MonilBhavsar

Cool. Thanks! Do you want to create a PR for this? cc @MonilBhavsar @teneeto @alitoshmatov

@marcaaron

Yes @marcaaron

Cool I can review it let's gooo 🙇

@marcaaron

@marcaaron created a PR

@laurenreidexpensify

Issue is ready for payment but no BZ is assigned. @laurenreidexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@Pujan92

Payment Summary

Upwork Job

ROLE: @Pujan92 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@laurenreidexpensify)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

Job added to Upwork: https://www.upwork.com/jobs/~018ed1f3e02054d0aa

@jjcoffee

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

@Pujan92

@Pujan92 correct job link for upwork here https://www.upwork.com/jobs/~018ed1f3e02054d0aa

@Pujan92

@Pujan92 correct job link for upwork here https://www.upwork.com/jobs/~018ed1f3e02054d0aa

Thanks, applied @laurenreidexpensify

Offer sent!

Offer sent!

Accepted!

@Pujan92

Payment Summary

C+ Review @Pujan92 paid in Upwork $500

Navigation Menu

Repository navigation

[$500] [HOLD for payment 2024-01-17] Expense - App crashes when attempting to request money from a deleted workspace #34063

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

12 remaining items

Payment Summary

BugZero Checklist (@laurenreidexpensify)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$500] [HOLD for payment 2024-01-17] Expense - App crashes when attempting to request money from a deleted workspace #34063

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Jan 5, 2024

melvin-bot commented on Jan 5, 2024

Pujan92 commented on Jan 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

marcaaron commented on Jan 5, 2024

Pujan92 commented on Jan 5, 2024

marcaaron commented on Jan 5, 2024

Pujan92 commented on Jan 5, 2024

12 remaining items

melvin-bot commented on Jan 17, 2024

melvin-bot commented on Jan 17, 2024

Payment Summary

BugZero Checklist (@laurenreidexpensify)

melvin-bot commented on Jan 18, 2024

melvin-bot commented on Jan 18, 2024

laurenreidexpensify commented on Jan 18, 2024

Pujan92 commented on Jan 18, 2024

laurenreidexpensify commented on Jan 18, 2024

Pujan92 commented on Jan 18, 2024

laurenreidexpensify commented on Jan 18, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions