[$500] BA - When page is reloaded in any form page, "Open in app" banner turns dark mode

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.23-0
Reproducible in staging?: Y
Reproducible in production?: Cannot test on prod
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: user must have New Expensify app installed and set light mode

Go to Settings > Workspace > Bank account
Start the add bank account flow
In any form page, reload the page

Expected Result:

The "Open in app" banner should remain in light mode

Actual Result:

The "Open in app" banner turns to dark mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6336784_1704813052853.Cumh5666_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b0434639aab4eb51
Upwork Job ID: 1745355229456834560
Last Price Increase: 2024-01-11
Automatic offers:

ishpaul777 | Contributor | 28094255

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@bondydaa

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When page is reloaded in any form page, "Open in app" banner turns dark mode

What is the root cause of that problem?

App/src/components/CustomStatusBarAndBackground/index.tsx

Lines 97 to 100 in 5df6055

    
           if (newStatusBarStyle !== statusBarStyle) { 
        
               updateStatusBarAppearance({statusBarStyle: newStatusBarStyle}); 
        
               setStatusBarStyle(newStatusBarStyle); 
        
           }

☝️ here the status bar color is only changes when newStatusBarStyle !== statusBarStyle which seems to be wrong conditional

offending PR- #33200

What changes do you think we should make in order to solve the problem?

Change it back to what it was before:

           if (newStatusBarStyle === statusBarStyle) {
                updateStatusBarAppearance({backgroundColor: currentScreenBackgroundColor});
            } else {
                updateStatusBarAppearance({backgroundColor: currentScreenBackgroundColor, statusBarStyle: newStatusBarStyle});
                setStatusBarStyle(newStatusBarStyle);
            }

I am available to raise a quick PR as this is a Deploy blocker

@ishpaul777

@ishpaul777 the proposal makes sense (not tested) but how can you show smart banner in dev?

this is reporducable for status bar on simulator, smart banner just uses status bar color

@ishpaul777

@ishpaul777's proposal looks good and tests well.
cc: @bondydaa

Simple repro step:

Be in light mode
Open any chat
Refresh app

@roryabraham

if this was caused by #33200 then it's not a blocker b/c that was deployed to prod it looks like.

I posted on on that issue to get @roryabraham and @situchan 's 👀 on it but going to remove the blocker for now.

right, already in production

Reproducible in production?: Cannot test on prod - this is the only reason for marking as deploy blocker I think

PR is merged and deployed to prod

not overdue

self-assigning to get payments sent now that regression period is over.

@ishpaul777

PAYMENT SUMMARY:

Fix: @ishpaul777 [$500] Offer Link
PR Review: @parasharrajat [$500] - PAYMENT IN NEWDOT

@ishpaul777

@ishpaul777 payment sent and contract ended - thank you! 🎉

@abekkala

@abekkala Feel free to close it. I will request later. Thanks.

Payment requested as per #34154 (comment)

@parasharrajat

$500 approved for @parasharrajat

Navigation Menu

Repository navigation

[$500] BA - When page is reloaded in any form page, "Open in app" banner turns dark mode #34154

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

72 remaining items

PAYMENT SUMMARY:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (newStatusBarStyle !== statusBarStyle) {
	updateStatusBarAppearance({statusBarStyle: newStatusBarStyle});
	setStatusBarStyle(newStatusBarStyle);
	}

[$500] BA - When page is reloaded in any form page, "Open in app" banner turns dark mode #34154

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Jan 9, 2024

melvin-bot commented on Jan 9, 2024

ishpaul777 commented on Jan 9, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

aimane-chnaif commented on Jan 9, 2024

ishpaul777 commented on Jan 9, 2024

aimane-chnaif commented on Jan 9, 2024

bondydaa commented on Jan 9, 2024

aimane-chnaif commented on Jan 9, 2024

72 remaining items

ishpaul777 commented on Mar 1, 2024

ishpaul777 commented on Mar 4, 2024

abekkala commented on Mar 7, 2024

abekkala commented on Mar 7, 2024

PAYMENT SUMMARY:

abekkala commented on Mar 7, 2024

parasharrajat commented on Mar 7, 2024

parasharrajat commented on May 20, 2024

JmillsExpensify commented on May 31, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions