You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
IOU - An administrator cannot edit an unpaid IOU created by an employee #34181
Version Number: 1.4.23-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Preconditions:
In OldDot under admin, create a Collect group policy, enable categories and add 3 categories, add an employee to the policy.
Open New Expensify app
Log in to the employee's account
Tap on the green plus button (FAB)
Select Request money
Select any currency and amount
Click next
Choose a group policy room
Click on "Show more"
Select a category and fill in the rest of the required data
Complete the IOU request
Re-login with the administrator account
Navigate to the WS room where the IOU was sent
Open the IOU created by the employee
Try editing the IOU details
Expected Result:
The administrator should be able to edit an unpaid IOU created by an employee
Actual Result:
An administrator cannot edit an unpaid IOU created by an employee
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@youssef-lr can you confirm this was a regression from your PR and if so, work on a fix for it? If you confirm it's not related to your PR, please assign it back to me. @unicorndev-727 thanks for the initial RCA!
Removing blocker for now, will wait for confirmation from Tom whether or not reports in Free policies can be edited by admins while they're still open.
Activity
github-actions commentedon Jan 9, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jan 9, 2024
Triggered auto assignment to @tgolen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.unidev727 commentedon Jan 9, 2024
Proposal
from: @unicorndev-727
Please re-state the problem that we are trying to solve in this issue.
IOU - An administrator cannot edit an unpaid IOU created by an employee
What is the root cause of that problem?
The root cause is that only isRequestor can edit if the report is not approved or settled here.
App/src/libs/ReportUtils.ts
Line 1901 in 5d0931d
This is derived from this #33633
What changes do you think we should make in order to solve the problem?
We need to update like this.
What alternative solutions did you explore?
N/A
tgolen commentedon Jan 9, 2024
@youssef-lr can you confirm this was a regression from your PR and if so, work on a fix for it? If you confirm it's not related to your PR, please assign it back to me. @unicorndev-727 thanks for the initial RCA!
Pujan92 commentedon Jan 9, 2024
Is it intentional to not allow edit when the status is OPEN as I am seeing the comment in that PR.
App/src/libs/ReportUtils.ts
Lines 1896 to 1898 in 5d0931d
youssef-lr commentedon Jan 9, 2024
Correct @Pujan92, the report is not submitted yet, so the admin shouldn't be able to edit it. cc @trjExpensify we can close this right?
youssef-lr commentedon Jan 9, 2024
Removing blocker for now, will wait for confirmation from Tom whether or not reports in Free policies can be edited by admins while they're still open.
trjExpensify commentedon Jan 9, 2024
How are there
openreports on free workspaces, given that the report start out onprocessing? 😕youssef-lr commentedon Jan 12, 2024
ah looks like this was tested on a Collect workspace, as per OP:
My I missed this. I think we're good here.