Skip to content

[$500] [HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] LHN - Clicking the (FAB) after opening the modal does not close the modal #34185

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.23-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1: Sign in to the staging environment of Expensify.
2: Click on the Floating Action Button (FAB) to open the modal.
3: Click on the FAB again; the modal should close

Expected Result:

After opening the modal, clicking on the FAB again should close the modal

Actual Result:

The modal does not close after opening, even when clicking on the FAB again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6337079_1704830896228.Screen5.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0178ff077f70abe686
  • Upwork Job ID: 1748053502135980032
  • Last Price Increase: 2024-01-18

Activity

  1. github-actions commented on Jan 9, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jan 9, 2024

    @melvin-bot

    Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. dummy-1111 commented on Jan 9, 2024

    @dummy-1111
    Contributor

    This is a regression of this PR #33247

  4. melvin-bot commented on Jan 9, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  5. roryabraham commented on Jan 9, 2024

    @roryabraham
    Contributor

    Fix is being CP'd to staging, cheers to @situchan for the quick fix

  6. 15 remaining items

  7. melvin-bot commented on Jan 18, 2024

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  8. marcochavezf commented on Jan 18, 2024

    @marcochavezf
    Contributor

    Hi @joekaufmanexpensify, could you handle the payment for @situchan for fixing this deploy blocker?

  9. changed the title [-][HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] LHN - Clicking the (FAB) after opening the modal does not close the modal[/-] [+][$500] [HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] LHN - Clicking the (FAB) after opening the modal does not close the modal[/+] on Jan 18, 2024
  10. melvin-bot commented on Jan 18, 2024

    @melvin-bot
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 18, 2024
  12. melvin-bot commented on Jan 18, 2024

    @melvin-bot

    Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

  13. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 18, 2024
  14. joekaufmanexpensify commented on Jan 18, 2024

    @joekaufmanexpensify
    Contributor

    @situchan offer sent for $500!

  15. joekaufmanexpensify commented on Jan 18, 2024

    @joekaufmanexpensify
    Contributor

    @situchan $500 sent and contract ended!

  16. joekaufmanexpensify commented on Jan 18, 2024

    @joekaufmanexpensify
    Contributor

    All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions